Skip to content

properly delete connected edges when deleting pods #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

properly delete connected edges when deleting pods #228

merged 1 commit into from
Feb 27, 2023

Conversation

lihebi
Copy link
Collaborator

@lihebi lihebi commented Feb 27, 2023

Previously, when a pod is deleted:

  1. the deletePods GraphQL API call is fired.
  2. the deleteEdge GraphQL API call is fired for all connected edges.

However, the deletePods operation might be executed before the edges are deleted, causing errors.

Now, this PR makes deletePods delete connected edges as well before the actual deleting of pods.

@lihebi lihebi merged commit 13bda66 into codepod-io:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lihebi