Skip to content

Fix: Minor fixes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Fix: Minor fixes #207

merged 2 commits into from
Jan 23, 2023

Conversation

li-xin-yi
Copy link
Collaborator

  1. Unselect all pods when a codeNode or richNode is focused.
  2. Enlarge the difference when comparing the position value. Number.EPSILON is too small.

@li-xin-yi
Copy link
Collaborator Author

Update:

Enable debug mode for richNode, clean up the hard code hacking of disabling selection on focus for richNode (because it is solved in the latest reactflow by default, we no longer need to listen to keyboard event).

Known issues:

  1. I suggest moving toggles in "site settings" into the right-click menu to make the sidebar looks more light.
  2. nodes are re-rendered every time their position changes because xPos and yPos changes, causing a lot of overhead, which is even worse in richNode because we don't memo the editor.
    image

Let's solve them in the future work if necessary.

@li-xin-yi li-xin-yi changed the title [WIP] Minor fixes FIx: Minor fixes Jan 21, 2023
@li-xin-yi li-xin-yi changed the title FIx: Minor fixes Fix: Minor fixes Jan 21, 2023
Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lihebi lihebi merged commit b03e17c into codepod-io:main Jan 23, 2023
li-xin-yi added a commit to li-xin-yi/codepod-1 that referenced this pull request Feb 1, 2023
* minor fix

* devmode for rich && clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants