Feat: single-pod cut-n-paste support #165
Conversation
|
Thanks, Xinyi! Yes, this is what we want. @forrestbao FYI, this would complete #99 and deprecate #143 Later, we'll have another PR to support copy/cut for a scope (recursively for all descendants). |
|
Update: Check if there is an in-progress pasting before exiting. If there is, do what Esc does. |
li-xin-yi
changed the title
| @@ -1344,12 +1394,16 @@ export function Canvas() { | |||
| checkNodesEndLocation(event, [currentNode], "ROOT"); | |||
| //clear the pasting state | |||
| setPasting(null); | |||
| // delete the original (hidden) node | |||
| if (cutting) { | |||
| reactFlowInstance.deleteElements({ nodes: [{ id: cutting }] }); | |||
There was a problem hiding this comment.
When cutting, once the user left-click to drop the node, it will trigger:
- add the new node (the
addPod(apolloClient, ...)above) - delete the original hidden node.
I'm having some trouble with 2. This line seems to trigger deletePod(null, ...) in nodes.tsx, so there won't be a remote deletePod graphql query. But I do see a deletePod query. Can you point out where does that deletePod query come from?
There was a problem hiding this comment.
I see. It should come from onNodesDelete.
There was a problem hiding this comment.
Yes, it triggers onNodeChanges's delete type when deleteElements is called, which deletes the corresponding in nodesMap, any deletion in nodesMap invokes a deletePod(null, ...) call.
I generalized the logic in #184. This PR is almost done, except I need a better implementation to create a scope as well as its children in DB at once. You can try that PR to see if it is the expected behavior of scope cut-copy-paste.
There was a problem hiding this comment.
Ah, I see, thanks. Yeah, that PR is a great reference on this. I'll take a close look.
Don't merge now, this is just a demo to align the idea of cut-n-paste functionality and tests. The code is too dirty now, clean-up is required after we agree on the idea.Update: clean-up & ready for review.
How to use:
Note:
Any test and suggestion are welcome.