fix(ui): remove bg and circle button on scope's bar #153
Conversation
ui/src/components/Canvas.tsx
Outdated
| if ( | ||
| mousePos.x < currentParent.positionAbsolute!.x || | ||
| mousePos.x > | ||
| currentParent.positionAbsolute!.x + currentParent.width! || | ||
| currentParent.positionAbsolute!.x + currentParent.width! || | ||
| mousePos.y < currentParent.positionAbsolute!.y || | ||
| mousePos.y > | ||
| currentParent.positionAbsolute!.y + currentParent.height! | ||
| currentParent.positionAbsolute!.y + currentParent.height! |
There was a problem hiding this comment.
We seem to be still on a different formatter (we used prettier). Can you double check?
There was a problem hiding this comment.
A configuration file may be needed in ui's folder.
There was a problem hiding this comment.
Thanks for the suggestions! Since we have nothing to customize prettier, we just left it empty (which should apply the default options). Do you think this would work or not? Or did you use prettier but got this different formatting?
This means changing the habit of users by quite a lot. Currently Google Colab, DeepNote, Noteable, and Hex all use the hover tool bar/strip design for each cell. |
|
My thoughts and suggestions are mentioned above. A right sidebar or a hover tool bar/strip would improve the experience. |
#130
I think the whole canvas is too complicated to modify UI style and handle business logic at the same time.
It would be better to provide a right sidebar like the design tool, so that when you select scope or node, you can modify their styles or attributes.
It may also need a designer. :)