Skip to content

fix: #98 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2022
Merged

fix: #98 #130

merged 3 commits into from
Dec 10, 2022

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 9, 2022

@lihebi
Copy link
Collaborator

lihebi commented Dec 9, 2022

Thanks! I don't have too much opinion on the theming. @forrestbao does this coloring look good to you?

Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are using different formatter. Can you try to re-format using prettier?

@forrestbao
Copy link
Collaborator

Thanks! I don't have too much opinion on the theming. @forrestbao does this coloring look good to you?

Thanks for asking for my opinion @lihebi. Let's leave the color like that for now until we have a chance to consult a designer.

@fundon does the infill color gradually darkens as the nested level of scopes increases?

@fundon
Copy link
Contributor Author

fundon commented Dec 10, 2022

@fundon does the infill color gradually darkens as the nested level of scopes increases?

@forrestbao Currently defines 4 levels.

https://github.com/codepod-io/codepod/pull/130/files#diff-c77756d2a50928e8e187ebede6a09ee0bcde46f7035ce4362b892fe3986d285bR559-R565

It may be more intuitive to have a prototype design.

Screenshot 2022-12-10 at 10 37 38 AM

Copy link
Collaborator

@lihebi lihebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fangdun!

@lihebi lihebi merged commit 1d4438e into codepod-io:main Dec 10, 2022
@fundon fundon deleted the improve-scope-ui branch December 10, 2022 03:44
@forrestbao
Copy link
Collaborator

@fundon In the screenshot above, a scope box has a window like that of a code cell. But in the deployed code, a scope box still uses the the Windows 95 style. Did you forget to add the code for the frame style change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants