Fix: auth error auto redirect & tree-sitter load path & toast notification #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihebi
reviewed
Nov 29, 2022
Comment on lines
+83
to
+84
| { id, owner: { id: userId || "undefined"} }, | ||
| { id, collaboratorIds: { has: userId || "undefined"} }, |
There was a problem hiding this comment.
What is the purpose of the string "undefined" here?
There was a problem hiding this comment.
When a guest visits a public repo, the userId could be null, but we should still return the repo. Though OR relationship may be short-circuited by the condition public==true, a null userId still causes a type error for the following two conditions. (Yes, we can check the public field first and then start another query, but it may bring overhead)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the load path issue in parser, otherwise, a user can't enter a repo by URL directly. Thanks to @lihebi , but it doesn't promise the parser ready for analyzing code when you directly jump to a repo by URL. We may modify more code to support waiting for the loading in the future.
Fix the bug that a public repo can't be created. （But I think the UI can be improved, it looks a little misleading)
close #77