Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Bump parser to b859 #362

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Conversation

f-moya
Copy link
Contributor

@f-moya f-moya commented Mar 11, 2021

As Bump PHP parser indicates a major update has been done to the main library in charge of parsing php code into AST nodes.

There are some differences between the old and new php parser, the differences are mostly new nodes, as you can check in it's CHANGELOG. This new nodes have increased the resulting AST depth, which has forced us to modify both the DEFAULT_MASS_THRESHOLD and POINTS_PER_OVERAGE in order to avoid overwhelming existent users with new issues.

The approach that we have taken for manipulating this constants has been: "Avoid generating new issues for customers". Also, we did research about which was the approach used in the project for this kind of changes and seems like they were very empirical based. Being said that, I propose to try this settings and came back if we have any customer's reports about this.

@f-moya f-moya mentioned this pull request Mar 11, 2021
@nporteschaikin nporteschaikin merged commit 460d39c into codeclimate:master Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants