Skip to content

Commit 84cd768

Browse files
aardgooseaardgoose
andauthored
use recommended compile sequence (mrdoob#27055)
Co-authored-by: aardgoose <angus.sawyer@email.com>
1 parent c5b97d6 commit 84cd768

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

examples/jsm/renderers/webgl/WebGLBackend.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -605,12 +605,6 @@ class WebGLBackend extends Backend {
605605
gl.shaderSource( shader, code );
606606
gl.compileShader( shader );
607607

608-
if ( gl.getShaderParameter( shader, gl.COMPILE_STATUS ) === false ) {
609-
610-
console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( shader ) );
611-
612-
}
613-
614608
this.set( program, {
615609
shaderGPU: shader
616610
} );
@@ -633,14 +627,21 @@ class WebGLBackend extends Backend {
633627
const { fragmentProgram, vertexProgram } = pipeline;
634628

635629
const programGPU = gl.createProgram();
636-
gl.attachShader( programGPU, this.get( fragmentProgram ).shaderGPU );
637-
gl.attachShader( programGPU, this.get( vertexProgram ).shaderGPU );
630+
631+
const fragmentShader = this.get( fragmentProgram ).shaderGPU;
632+
const vertexShader = this.get( vertexProgram ).shaderGPU;
633+
634+
gl.attachShader( programGPU, fragmentShader );
635+
gl.attachShader( programGPU, vertexShader );
638636
gl.linkProgram( programGPU );
639637

640638
if ( gl.getProgramParameter( programGPU, gl.LINK_STATUS ) === false ) {
641639

642640
console.error( 'THREE.WebGLBackend:', gl.getProgramInfoLog( programGPU ) );
643641

642+
console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( fragmentShader ) );
643+
console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( vertexShader ) );
644+
644645
}
645646

646647
gl.useProgram( programGPU );

0 commit comments

Comments
 (0)