Replies: 5 comments 5 replies
-
Yes I agree, that is a lot more elegant! You can see PR #28 for a potential solution. |
Beta Was this translation helpful? Give feedback.
-
Mmh, I am not sure if I like the preceding '?'. Do we really need this? The expression is just a function returning a Scala Boolean, right? So we can use any ChiselTest code (peek). I don't understand why this collides with Chisel operators, we are in Scala land, right? Another proposal: for quick and dirty tests we can have an optional delay (say 100 clock cycles) to state:
Maybe having the delay as a parameter, such as:
|
Beta Was this translation helpful? Give feedback.
-
I think the proposed syntactic sugar is orthogonal to the timed assertion topic. It could also be used in general testing. I would stick to normal Chisel test code within the code block. We shall discuss if we want to add those funny operators to ChiselVerify in general. However, there is a complexity danger here when adding too many operators. We might end up beating SystemVerilog by having more than 250 keywords/operators in Chisel/ChiselTest/ChiselVerify. Let's move the operator discussion to #29 |
Beta Was this translation helpful? Give feedback.
-
Mmh, shouldn't eventually be a condition that is eventually true? I did not think about a comparison of values from different clock cycles. This might be interesting as well, but a different use case. If we mimic ScalaTest, then it is a boolean condition that might become true some cycle within the limit. We should look at what SV has for a double-check.
BTW: did I mention that I think |
Beta Was this translation helpful? Give feedback.
-
We shall use by-name paramters to drop
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
ScalaTest has the following notion on eventually (from the Scala book):
Maybe we should follow this style for our timed assertions.
Beta Was this translation helpful? Give feedback.
All reactions