Skip to content

Commit ed31bcd

Browse files
authored
fix(input-group): Styling fix for dropdowns, radio and checkbox groups. Fixes #2114,#1560 (#2118)
* Create input-group.css * import css into input-group * dropdown use input-group.css * form-radio-group import input-group.css * form-checkbox-group import input-group.css * dropdown add comment * dropdown.css replaced by input-group.css
1 parent ada4f2c commit ed31bcd

File tree

6 files changed

+27
-17
lines changed

6 files changed

+27
-17
lines changed

src/components/dropdown/dropdown.css

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/components/dropdown/dropdown.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import idMixin from '../../mixins/id'
22
import dropdownMixin from '../../mixins/dropdown'
33
import bButton from '../button/button'
44

5-
import './dropdown.css'
5+
// Needed when dropdowns are inside an input group
6+
import '../input-group/input-group.css'
67

78
export default {
89
mixins: [idMixin, dropdownMixin],

src/components/form-checkbox/form-checkbox-group.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ import formCustomMixin from '../../mixins/form-custom'
77

88
import bFormCheckbox from './form-checkbox'
99

10+
// Needed when checknox-groups are inside an input group
11+
import '../input-group/input-group.css'
12+
1013
export default {
1114
mixins: [
1215
idMixin,

src/components/form-radio/form-radio-group.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ import formStateMixin from '../../mixins/form-state'
66
import formCustomMixin from '../../mixins/form-custom'
77
import bFormRadio from './form-radio'
88

9+
// Needed when radio-groups are inside an input group
10+
import '../input-group/input-group.css'
11+
912
export default {
1013
mixins: [
1114
idMixin,
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
/* workaround for https://github.com/bootstrap-vue/bootstrap-vue/issues/1560 */
2+
/* workaround for https://github.com/bootstrap-vue/bootstrap-vue/issues/2114 */
3+
/* source: _input-group.scss */
4+
5+
.input-group > .input-group-prepend > .btn-group > .btn,
6+
.input-group > .input-group-append:not(:last-child) > .btn-group > .btn,
7+
.input-group > .input-group-append:last-child > .btn-group:not(:last-child):not(.dropdown-toggle) > .btn {
8+
border-top-right-radius: 0;
9+
border-bottom-right-radius: 0;
10+
}
11+
12+
.input-group > .input-group-append > .btn-group > .btn,
13+
.input-group > .input-group-prepend:not(:first-child) > .btn-group > .btn,
14+
.input-group > .input-group-prepend:first-child > .btn-group:not(:first-child) > .btn {
15+
border-top-left-radius: 0;
16+
border-bottom-left-radius: 0;
17+
}

src/components/input-group/input-group.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import InputGroupPrepend from './input-group-prepend'
33
import InputGroupAppend from './input-group-append'
44
import InputGroupText from './input-group-text'
55

6+
import './input-group.css'
7+
68
export const props = {
79
id: {
810
type: String,

0 commit comments

Comments
 (0)