Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.5.0
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.5.1
Choose a head ref
  • 1 commit
  • 3 files changed
  • 2 contributors

Commits on Jul 6, 2025

  1. fix(pypi): only generate namespace package shims if implicit namespac… 

    …es are disabled (#3059)

The refactoring to move the pkgutil shim generation to build phase
inverted
the logic for when it should be activated. When
`enable_implicit_namespace_pkgs=True`, it means to not generate the
pkgutil shims
("respect the Python definition of the namespace package").

To fix, just invert the logic that activates it.

A test will be added in a subsequent PR because the necessary helper
isn't
in the 1.5 branch.

Fixes #3038

---------

Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
(cherry picked from commit 47c681b)
    @rickeylev @aignas
    rickeylev and aignas committed Jul 6, 2025
    Configuration menu
    Copy the full SHA
    18d0d29 View commit details
    Browse the repository at this point in the history
Loading