fix(account): Update error message when asking for a contract that is not verified by etherscan

sebs · sebs · commit 242d85a9e5ef · 2018-10-08T15:24:38.000+02:00
* BC break, major release
* error is not 'NOTOK' anymore, ubt a conrete error message
* still ways to improve
diff --git a/lib/get-request.js b/lib/get-request.js
@@ -37,7 +37,11 @@ module.exports = function(chain, timeout) {
         var data = response.data;
 
         if (data.status && data.status != 1) {
-          return reject(data.message);
+          let returnMessage = 'NOTOK';
+          if (data.result && typeof data.result === 'string') {
+            returnMessage = data.result;
+          }
+          return reject(returnMessage);
         }
 
         if (data.error) {
diff --git a/package.json b/package.json
@@ -33,8 +33,8 @@
   },
   "homepage": "https://github.com/sebs/etherscan-api#readme",
   "devDependencies": {
-    "browserify": "^16.2.2",
-    "chai": "^4.0.2",
+    "browserify": "^16.2.3",
+    "chai": "^4.2.0",
     "changelog": "^1.4.2",
     "ink-docstrap": "^1.3.2",
     "jsdoc": "^3.5.5",
@@ -44,7 +44,7 @@
   },
   "dependencies": {
     "axios": "^0.18.0",
-    "gh-pages": "^2.0.0",
+    "gh-pages": "^2.0.1",
     "querystring": "^0.2.0"
   }
 }
diff --git a/test/methods-test.js b/test/methods-test.js
@@ -144,12 +144,15 @@ describe('api', function() {
       done();
     });
   });
-
-  xit('contract.getabi', function(done){
-    var api = init();
+  // test for bug #31
+  // see https://github.com/sebs/etherscan-api/issues/31
+  it('contract.getabi for a contract that is not verified by etherscan: error', function(done){
+    var api = init('test', 'ropsten', 10000);
     var abi = api.contract.getabi('0xBB9bc244D798123fDe783fCc1C72d3Bb8C189413');
-    abi.then(function(res){
-      assert.ok(res);
+    abi.then(function(){
+      assert.false(true, 'should not be a success');
+    }).catch(err=> {
+      assert.equal(err, 'Contract source code not verified');
       done();
     });
   });
