-
Notifications
You must be signed in to change notification settings - Fork 4
Closed
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: enhancementProposed improvementProposed improvement
Description
These lines of code:
Arduino_AdvancedAnalog/src/HALConfig.cpp
Line 166 in d989bcf
ADC_REGULAR_RANK_1, ADC_REGULAR_RANK_2, ADC_REGULAR_RANK_3, ADC_REGULAR_RANK_4, ADC_REGULAR_RANK_5 |
and
#define AN_MAX_ADC_CHANNELS (5) |
(also referenced, here:
Arduino_AdvancedAnalog/src/AdvancedADC.h
Line 39 in d989bcf
"A maximum of 5 channels can be sampled successively."); |
limit multi-channel sampling to a sequence of max length 5. The STM32H7 actually supports 16 channels (accordingly #defines up to ADC_REGULAR_RANK_16
exist), and arguably the feature is most useful when more than a handful of pins are involved.
Now, I am not quite sure what is the long term plan for cross-hardware support in this library. Depending on that, the proper fix will either be a plain adjustment of the values, or a small mess of #ifdefs.
Metadata
Metadata
Assignees
Labels
conclusion: resolvedIssue was resolvedIssue was resolvedtopic: codeRelated to content of the project itselfRelated to content of the project itselftype: enhancementProposed improvementProposed improvement