-
Notifications
You must be signed in to change notification settings - Fork 23
Comparing changes
Open a pull request
base repository: arduino-libraries/ArduinoGraphics
base: 1.1.1
head repository: arduino-libraries/ArduinoGraphics
compare: 1.1.2
- 9 commits
- 5 files changed
- 2 contributors
Commits on Feb 21, 2024
-
Fix regression: report size delta size on PR. (#39)
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
Configuration menu - View commit details
-
Copy full SHA for cac25ed - Browse repository at this point
Copy the full SHA cac25edView commit details -
Revert "Fix regression: report size delta size on PR. (#39)"
This reverts commit cac25ed.
Configuration menu - View commit details
-
Copy full SHA for ab427be - Browse repository at this point
Copy the full SHA ab427beView commit details -
Correct workflow artifact name pattern in size deltas report workflow
The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regular expression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow. The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's "actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was "sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer being generated by the workflow. Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a more strict regular expression. This will make it easier for maintainers and contributors to understand that this value is a regular expression and the exact nature of how that regular expression functio
Configuration menu - View commit details
-
Copy full SHA for c9ec0e4 - Browse repository at this point
Copy the full SHA c9ec0e4View commit details -
Merge pull request #40 from arduino-libraries/fix-compile-examples
Fix size deltas report infrastructure configuration
Configuration menu - View commit details
-
Copy full SHA for 9a2638e - Browse repository at this point
Copy the full SHA 9a2638eView commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 72388e2 - Browse repository at this point
Copy the full SHA 72388e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c067b6 - Browse repository at this point
Copy the full SHA 7c067b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d32f4e - Browse repository at this point
Copy the full SHA 8d32f4eView commit details -
Merge pull request #42 from arduino-libraries/upgrade-script
Update font generator script to work with python 3.x
Configuration menu - View commit details
-
Copy full SHA for 1322aa5 - Browse repository at this point
Copy the full SHA 1322aa5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9fdae1 - Browse repository at this point
Copy the full SHA e9fdae1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.1.1...1.1.2