Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino-libraries/ArduinoGraphics
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.1.1
Choose a base ref
...
head repository: arduino-libraries/ArduinoGraphics
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.1.2
Choose a head ref
  • 9 commits
  • 5 files changed
  • 2 contributors

Commits on Feb 21, 2024

  1. Fix regression: report size delta size on PR. (#39)

    The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
    aentinger authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    cac25ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab427be View commit details
    Browse the repository at this point in the history
  3. Correct workflow artifact name pattern in size deltas report workflow

    The "sketches-reports-source" input of the "arduino/report-size-deltas" GitHub Actions action defines the regular
    expression that matches the names of the sketches report workflow artifacts produced by the "Compile Examples" workflow.
    
    The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was
    adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's
    "actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was
    "sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the
    artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer
    being generated by the workflow.
    
    Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a
    more strict regular expression. This will make it easier for maintainers and contributors to understand that this value
    is a regular expression and the exact nature of how that regular expression functio
    aentinger committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c9ec0e4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #40 from arduino-libraries/fix-compile-examples

    Fix size deltas report infrastructure configuration
    aentinger authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    9a2638e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    72388e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c067b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8d32f4e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #42 from arduino-libraries/upgrade-script

    Update font generator script to work with python 3.x
    aentinger authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1322aa5 View commit details
    Browse the repository at this point in the history
  5. Release v1.1.2.

    aentinger authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e9fdae1 View commit details
    Browse the repository at this point in the history
Loading