Update to Go 1.16 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
per1234
commented
Aug 16, 2021
| go 1.14 | ||
| go 1.16 |
There was a problem hiding this comment.
I realize this change does not necessarily follow from the others, but it seems that in this case there are only downsides to indicating compatibility with a Go version we don't do any testing for. It's likely that arduino/library-registry is the only user of the module anyway, since this module's API currently only provides for reading the data format of the library registry file. The program in arduino/library-registry has already been updated to Go 1.16.
1.16 is now the preferred Go version for all Arduino tooling projects. The update from Go 1.14 to 1.16 broke the task that runs golint: ``` $ go mod tidy && task --silent go:lint no required module provides package golang.org/x/lint/golint: go.mod file not found in current directory or any parent directory; see 'go help modules' task: Failed to run task "go:lint": exit status 1 ``` The good news is that the new `go install` command eliminates the need for the workaround of running the `go get golang.org/x/lint/golint` command from outside the project path in order to avoid pollution of `go.sum`. The bad news is the `go list` command used to get the path of the golint installation does not work in the "module-aware mode" that is now the default (and will be the only mode in Go 1.17). In the end, I gave up on making the task work as before. I think it's better to require the user to install golint and put the installation in the system `PATH`, displaying a helpful message when this has not been done.
cmaglie
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.16 is now the preferred Go version for all Arduino tooling projects.
The update from Go 1.14 to 1.16 broke the task that runs golint:
The good news is that the new
go installcommand eliminates the need for the workaround of running thego get golang.org/x/lint/golintcommand from outside the project path in order to avoid pollution ofgo.sum.The bad news is the
go listcommand used to get the path of the golint installation does not work in the "module-aware mode" that is now the default (and will be the only mode in Go 1.17). In the end, I gave up on making the task work as before. I think it's better to require the user to install golint and put the installation in the systemPATH, displaying a helpful message when this has not been done.