Skip to content

Name conflict in library Storage #366

New issue
New issue
Closed
#370
Closed
Name conflict in library Storage#366
#370
Assignees
maidnl
Labels
conclusion: resolvedIssue was resolvedtopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project
@drmcnelson

Description

@drmcnelson
drmcnelson
opened on Aug 19, 2024

The referenced code from Storage/storage_common.h creates a name, debug and this name is visible in global scope.

It therefore conflicts with a name that is ubiquitous in user code.

Please correct this. It is not fair that thousands of users cannot use the name debug and have to change their long established code bases to accommodate this.

Thank you

ArduinoCore-renesas/libraries/Storage/storage_common.h

Lines 27 to 38 in 5748045

static inline void debug(const char *fmt, ...)
{
memset(debug_buffer,0x00,256);
va_list va;
va_start (va, fmt);
vsnprintf (debug_buffer,STORAGE_BUFF_DIM, fmt, va);
va_end (va);
if(Serial)
Serial.println(debug_buffer);
}

Metadata

Metadata

Assignees

Labels

conclusion: resolvedIssue was resolvedtopic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions