Skip to content

Add support for Python 3.11 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 1, 2023
Merged

Add support for Python 3.11 #83

merged 6 commits into from
Feb 1, 2023

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jan 24, 2023 •
edited
Loading

Fix #75

Building wheels for Py 3.11

erichare
erichare reviewed Jan 24, 2023
View reviewed changes
erichare
erichare reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@erichare erichare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BewareMyPower may have additional comments, this looks great to me but only immediate question i have is the removal of the 3.8 - 3.10 versions for the windows wheel builds and if we want to do that for sure.

BewareMyPower
BewareMyPower requested changes Jan 25, 2023
View reviewed changes
@BewareMyPower
Copy link
Contributor

It's weird that the MacOS test failed in https://github.com/apache/pulsar-client-python/actions/runs/4029658826/jobs/6927777767 after bc4144a but it succeeded before.

++ ./build-support/dep-version.py pulsar-cpp
Traceback (most recent call last):
  File "/Users/runner/work/pulsar-client-python/pulsar-client-python/./build-support/dep-version.py", line [21](https://github.com/apache/pulsar-client-python/actions/runs/4029658826/jobs/6927777767#step:6:22), in <module>
    import yaml, sys
ModuleNotFoundError: No module named 'yaml'
+ PULSAR_CPP_VERSION=

@BewareMyPower BewareMyPower added the enhancement New feature or request label Jan 28, 2023
@BewareMyPower BewareMyPower added this to the 3.1.0 milestone Jan 28, 2023
@BewareMyPower
Copy link
Contributor

It's caused by

pulsar-client-python/.github/workflows/ci-pr-validation.yaml

Line 158 in fe96604

if: steps.cache-deps.outputs.cache-hit != 'true'

We need to add pip install pyyaml in the workflow.

@merlimat merlimat merged commit c88d57e into apache:main Feb 1, 2023
@merlimat merlimat deleted the py-3.11 branch February 1, 2023 01:16
@merlimat merlimat mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichare erichare erichare left review comments

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Assignees

@merlimat merlimat

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

[feature request] release built distributions for python 3.11
3 participants
@merlimat @BewareMyPower @erichare