Skip to content

Upgrade fastavro to 1.7.3 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Upgrade fastavro to 1.7.3 #110

merged 1 commit into from
Apr 19, 2023

Conversation

BewareMyPower
Copy link
Contributor

Fixes #67

This PR fixes the client cannot be installed with [avro]. Take Python 3.11 on Windows as example:

D:\> py -m pip install 'pulsar_client-3.2.0a1-cp311-cp311-win_amd64.whl[avro]'
Processing d:\pulsar_client-3.2.0a1-cp311-cp311-win_amd64.whl
Requirement already satisfied: certifi in c:\users\xuyunze\appdata\local\programs\python\python311\lib\site-packages (from pulsar-client==3.2.0a1) (2022.12.7)
Collecting fastavro==1.7.3
  Using cached fastavro-1.7.3-cp311-cp311-win_amd64.whl (406 kB)
pulsar-client is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.
Installing collected packages: fastavro
Successfully installed fastavro-1.7.3

[notice] A new release of pip is available: 23.0.1 -> 23.1
[notice] To update, run: python.exe -m pip install --upgrade pip

TODO: fix the client cannot be installed with [all].

@BewareMyPower BewareMyPower added the bug Something isn't working label Apr 19, 2023
@BewareMyPower BewareMyPower added this to the 3.2.0 milestone Apr 19, 2023
@BewareMyPower BewareMyPower self-assigned this Apr 19, 2023
merlimat
merlimat reviewed Apr 19, 2023
View reviewed changes
setup.py
@@ -90,7 +90,7 @@ def build_extension(self, ext):
# avro dependencies
extras_require["avro"] = sorted(
{
"fastavro==0.24.0"
"fastavro==1.7.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just remove the version here and let pip resolve the latest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed version or at least a ^x.y.z manner can prevent unintentional version bump?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we let pip resolve the latest, maybe the support for some older Python versions might be dropped unexpectedly.

I think we should add extra workflows to verify the compatibility for the lowest version and highest version that we supported.

@merlimat merlimat merged commit 623df3a into apache:main Apr 19, 2023
@BewareMyPower BewareMyPower deleted the bewaremypower/fastavro branch April 20, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@merlimat merlimat merlimat approved these changes

@RobertIndie RobertIndie Awaiting requested review from RobertIndie

@Demogorgon314 Demogorgon314 Awaiting requested review from Demogorgon314

@shibd shibd Awaiting requested review from shibd

Assignees

@BewareMyPower BewareMyPower

Labels
bug Something isn't working
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[bug] The fastavro dependency is unavailable on Windows
3 participants
@BewareMyPower @merlimat @tisonkun