Skip to content

refactor(signal-forms): rework metadata API #62713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: prototype/signal-forms
Choose a base branch
from

Conversation

mmalerba
Copy link
Contributor

Note: each commit is an independently reviewable step if you prefer to review commit-by-commit.

I still have a few open questions:

  1. Do we prefer the name metadata or property for this concept?

  2. What should be the names of the functions used to bind logic to MetadataKey and AggregateMetadataKey.
    Some ideas for MetadataKey include:

    • metadata (or property)
    • setMetadata (or setProperty)

    Some ideas for AggregateMetadataKey include:

    • addMetadata (or addProperty)
    • addToMetadata (or addToProperty)
    • aggregateMetadata (or aggregateProperty)
    • accumulateMetadata (or accumulateProperty)
    • contributeMetadata (or contributeToProperty)
  3. It can be tedious to type the generic MetadataKey.create<...>() for a key that you use internally to the schema. I'm worried people will just yolo and MetadataKey.create<any>(), should we add back an equivalent to the 2-parameter variant of define?

@mmalerba mmalerba requested review from leonsenft, kirjs and alxhub July 18, 2025 21:57
@mmalerba mmalerba added area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jul 18, 2025
@ngbot ngbot bot added this to the Backlog milestone Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: forms target: feature This PR is targeted for a feature branch (outside of main and semver branches)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant