-
Notifications
You must be signed in to change notification settings - Fork 26.4k
docs: Correct description of lesson outcome #62710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this
@@ -103,7 +103,7 @@ In your IDE: | |||
Then, save the changes you made to `app.ts`. | |||
|
|||
1. If you stopped the `ng serve` command from step 1, in the **Terminal** window of your IDE, run `ng serve` again. | |||
1. Open your browser and navigate to `localhost:4200` and confirm that the app builds without error and displays *Hello world* in the title and body of your app: | |||
1. Open your browser and navigate to `localhost:4200` and confirm that the app builds without error and displays *Homes* in the title and *Hello world* in the body of your app: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, is it plural? Like Homes
, not Home
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's what we have here : https://github.com/angular/angular/blob/main/adev/src/content/tutorials/first-app/steps/02-Home/src/index.html#L5
Also we'll need you to reword the commit message to follow our guidelines. It should a |
49d635e
to
e8c0f5d
Compare
Done, commit message reformulated. Thank you |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information