Skip to content

refactor(devtools): enable view source for template effects #62692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milomg
Copy link
Member

@milomg milomg commented Jul 17, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Use inspect(class instance.constructor) to jump to the source of components when trying to inspect template effects

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Use inspect(class instance.constructor) to jump to the source of
components when trying to inspect template effects
@pullapprove pullapprove bot requested a review from crisbeto July 17, 2025 20:25
@ngbot ngbot bot added this to the Backlog milestone Jul 17, 2025
@milomg milomg requested a review from JeanMeche July 18, 2025 21:11
@@ -133,6 +133,7 @@ function getNodesAndEdgesFromSignalMap(signalMap: ReadonlyMap<ReactiveNode, Reac
label: consumer.debugName ?? consumer.lView?.[HOST]?.tagName?.toLowerCase?.(),
kind: consumer.kind,
epoch: consumer.version,
debuggableFn: consumer.lView?.[CONTEXT]?.constructor as (() => unknown) | undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't really obvious, can we add a comment to hint what that constructor refers to ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants