Skip to content

Set the correct detail message for passed steps (fix #835) #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

Set the correct detail message for passed steps (fix #835) #853

merged 2 commits into from
Apr 24, 2025

Conversation

sharovd
Copy link
Contributor

@sharovd sharovd commented Apr 7, 2025 •
edited
Loading

Context

Report Robot Report Allure

Checklist

@delatrie delatrie self-assigned this Apr 8, 2025
delatrie
delatrie requested changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sharovd ! Thank you very much for contributing to allure-python.

I've checked the changes, and the code looks good to me. The only missing thing is a test that reproduces the issue. Could you pls add one?

If you need some guidance on how to test allure-robotframework, please let me know, and I will gladly help you.

@delatrie delatrie linked an issue Apr 21, 2025 that may be closed by this pull request
allure_robotframework sets incorrect statusDetails message for steps #835
Closed
@sharovd
Copy link
Contributor Author

sharovd commented Apr 24, 2025 •
edited
Loading

Hi, @delatrie! Thanks for the review!
I've added the test test_only_failed_steps_have_status_details() that reproduces the problem described. I have verified that it fails on the master branch and passes with my changes.
The test follows the structure of the existing ones in the repository, but if you spot anything that could be improved, feel free to tell me.

delatrie
delatrie approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@delatrie delatrie merged commit 68bbafe into allure-framework:master Apr 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie approved these changes

Assignees

@delatrie delatrie

Labels
theme:robotframework type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allure_robotframework sets incorrect statusDetails message for steps
2 participants
@sharovd @delatrie