Skip to content

Add py.typed marker file for PEP-561 support #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

coreegor
Copy link

Context

Add py.typed marker file for the PEP-561 support
fixes #731

Checklist

@delatrie
Copy link
Contributor

delatrie commented Apr 2, 2025

Hi, @coreegor, thank you for your contribution!

Turns out it's a little bit trickier than simply adding py.typed because the API is exposed from a separate module, which is outside the allure_commons package. The solution is to convert allure from a module to a package and I've addressed that in #850.

TBH, I should've merged your PR first instead of just replacing it with another one. I apologize for that.

@delatrie delatrie closed this Apr 2, 2025
@coreegor
Copy link
Author

coreegor commented Apr 3, 2025

Hi, @delatrie
No big deal. The main thing is that the request was implemented. Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add py.typed marker files to conform PEP-561 and better typechecking
2 participants