Fix squashed results when using rerunfailures (fixes #735) #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhomuti
approved these changes
Mar 14, 2023
beckerGil
pushed a commit
to beckerGil/allure-python
that referenced
this pull request
Apr 10, 2023
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes the regression when pytest-rerunfailures is used. The issue started to occur after the closing of a test result was moved from
pytest_runtest_logfinishtopytest_runtest_protocolto prevent the test result from being omitted from the output under certain conditions (e.g., ifpytest.exitwas called during fixture setup).To fix that, I put the closing of a test result back to
pytest_runtest_logfinishwhile still backing it up withpytest_runtest_protocolin casepytest_runtest_logfinishis not called. These two closings should cover both issues.Fixes #735.
Checklist