Skip to content

Fix internal UTBot timeout exception rendering in summaries #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

sofurihafe
Copy link
Member

Description

This PR makes TimoutException originating from the engine being rendered as a suspicious behavior not as an thrown exception.
Also, added extra summary test (SummaryExceptionExampleTest::testHangForSeconds) regarding the fix.

Previous rendering:

@utbot.throwsException { @link org.utbot.framework.plugin.api.TimeoutException } in: return seconds;

Current rendering:

@utbot.detectsSuspiciousBehavior in: return seconds;

Fixes #1832

How to test

Automated tests

utbot-samples.

Also, added extra summary test (SummaryExceptionExampleTest::testHangForSeconds) regarding the fix.

@sofurihafe sofurihafe added comp-summaries Something related to the method names, code comments and display names generation ctg-bug-fix PR is fixing a bug labels Feb 27, 2023
@EgorkaKulikov EgorkaKulikov self-requested a review February 27, 2023 14:47
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it after comments fix

@sofurihafe sofurihafe force-pushed the andrey-t/summaries_timeout_error branch from b1ada05 to 77c05be Compare February 27, 2023 14:54
@sofurihafe sofurihafe enabled auto-merge (squash) February 27, 2023 14:55
@sofurihafe sofurihafe force-pushed the andrey-t/summaries_timeout_error branch from 77c05be to d372e5e Compare February 27, 2023 18:51
@sofurihafe sofurihafe merged commit d8daca8 into main Feb 27, 2023
@sofurihafe sofurihafe deleted the andrey-t/summaries_timeout_error branch February 27, 2023 19:08
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-summaries Something related to the method names, code comments and display names generation ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout exception (internal of UtBot) is dispayed in Summaries
3 participants