Add cache with LIFO replacement policy #6390
Open
+903
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6390 +/- ##
============================================
+ Coverage 74.62% 74.82% +0.19%
- Complexity 5455 5489 +34
============================================
Files 682 683 +1
Lines 19009 19163 +154
Branches 3671 3694 +23
============================================
+ Hits 14185 14338 +153
+ Misses 4262 4261 -1
- Partials 562 564 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KevinMwita7
requested review from
DenizAltunkapan,
yanglbme,
vil02 and
alxkm
as code owners
DenizAltunkapan
requested changes
Jul 20, 2025
|
|
||
| while (it.hasNext()) { | ||
| K k = it.next(); | ||
| CacheEntry<V> entry = cache.get(k); |
There was a problem hiding this comment.
Try using the final keyword for local variables where possible @KevinMwita7
| private LIFOCache(Builder<K, V> builder) { | ||
| this.capacity = builder.capacity; | ||
| this.defaultTTL = builder.defaultTTL; | ||
| this.cache = HashMap.newHashMap(builder.capacity); |
There was a problem hiding this comment.
I didn't know there is such static method... A suggestion could be using the classic constructor new HashMap<>(builder.capacity)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a reusable LIFOCache implementation with the following features:
Fixed size LIFO eviction policy using Deque as stack and HashMap as cache
Time to live (TTL)
Thread-safe operations using ReentrantLock
Pluggable EvictionStrategy to control expired entry cleanup
Eviction listener callback support for observing removals
Hit and miss statistics tracking
Builder for flexible configuration
I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized it.
All filenames are in PascalCase.
All functions and variable names follow Java naming conventions.
All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
All new code is formatted with
clang-format -i --style=file path/to/your/file.java