Consider x-correlation-id as well #64
Conversation
The library currently considers the header fields `x-correlationid` and `x-vcap-request-id` as carrying correlation IDs. This change would also make it aware of the field `x-correlation-id`, which is widely used in the web, today. The settings would introduce `x-correlation-id` as an alias, sub-ordinating it to the original field `x-correlationid`. Meaning, for example, the library will use `x-correlationid` > `x-correation-id` > `x-vcap-request-id`, in this order of preference. The field would not be propagated back to the request sender, although this can probably be discussed. This PR is an incomplete suggestion, to make the dimension of the changes to the production code clear. It does not adjust the unit alongside, so any automatic PR voters will/should reject this change.
|
Thanks or your contribution. We have issue #45 addressing exactly this question. Adding the alias in the library is rather easy, as demonstrated by your PR. But there are some more things to consider here. Main focus of this library is to aid development of Java applications running on the SAP Cloud Platform using the Cloud Foundry stack. This platform centrally generates request logs in the gorouter, that are shipped along the application logs filtered by this library. The request logs however, only contain a selected set of HTTP headers. This set contains the already supported |
|
|
The library currently considers the header fields
x-correlationidandx-vcap-request-idas carrying correlation IDs. This change would also make it aware of the fieldx-correlation-id, which is widely used in the web, today.The settings would introduce
x-correlation-idas an alias, sub-ordinating it to the original fieldx-correlationid. Meaning, for example, the library will usex-correlationid>x-correation-id>x-vcap-request-id, in this order of preference. The field would not be propagated back to the request sender, although this can probably be discussed.This PR is an incomplete suggestion, to make the dimension of the changes to the production code clear. It does not adjust the unit alongside, so any automatic PR voters will/should reject this change.