-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Set {min,max}_arity
#5994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set {min,max}_arity
#5994
Conversation
WalkthroughThe code refactors the logic for deriving argument parsing in procedural macros. It introduces trait-based parsing of field attributes, derives defaults for relevant types, and implements dynamic computation of arity bounds based on parsed attributes. Error handling is improved using idiomatic Rust traits, and code organization is clarified for maintainability. Changes
Sequence Diagram(s)sequenceDiagram
participant Macro as Derive Macro
participant Field as Struct Field
participant Attr as ArgAttribute
participant Bounds as ArityBounds
Macro->>Field: Iterate over fields
Field->>Attr: Parse attributes (TryFrom<&Field>)
Macro->>Bounds: compute_arity_bounds(all ArgAttributes)
Macro->>Macro: Generate FromArgs impl using attributes and bounds
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)**/*.rsInstructions used from: Sources:
🧠 Learnings (1)📓 Common learnings
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #5980
Summary by CodeRabbit
Refactor
Bug Fixes