Skip to content

Implement properties on _TextIOBase and StringIO #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

Implement properties on _TextIOBase and StringIO #5987

merged 2 commits into from
Jul 17, 2025

Conversation

ever0de
Copy link
Contributor

@ever0de ever0de commented Jul 16, 2025 •
edited by coderabbitai bot
Loading

ref

Summary by CodeRabbit

  • New Features
    • Added errors and line_buffering properties to text I/O objects, providing default attribute access for improved compatibility.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025 •
edited
Loading

Walkthrough

The _TextIOBase class in the _io module was updated with a new errors property getter that returns None. The StringIO class was also updated with a new line_buffering property getter that returns false. No other logic or control flow was changed.

Changes

File(s) Change Summary
vm/src/stdlib/io.rs Added errors property getter to _TextIOBase and line_buffering property getter to StringIO

Poem

Two new getters join the show,
errors and line_buffering—now you know!
One says “None,” the other “False” with grace,
Adding simple traits to the _TextIOBase.
A bunny hops with code delight,
For properties set just right! 🐇

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c44036f and 16c5ce5.

📒 Files selected for processing (1)
  • vm/src/stdlib/io.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • vm/src/stdlib/io.rs
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ever0de ever0de changed the title fix(stdlib/io): Implement missing properties(errors, line_buffering) … Implement missing properties(errors, line_buffering) on _TextIOBase Jul 16, 2025
youknowone
youknowone reviewed Jul 16, 2025
View reviewed changes
vm/src/stdlib/io.rs
@@ -738,6 +738,16 @@ mod _io {
fn encoding(_zelf: PyObjectRef, vm: &VirtualMachine) -> PyObjectRef {
vm.ctx.none()
}

#[pygetset]
fn errors(_zelf: PyObjectRef, vm: &VirtualMachine) -> PyObjectRef {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked errors is for TextIOBase, so this is looking good

vm/src/stdlib/io.rs Outdated
Comment on lines 747 to 750
#[pygetset]
fn line_buffering(_zelf: PyObjectRef) -> bool {
false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this one is different. Linked one is stringIO

@ever0de ever0de changed the title Implement missing properties(errors, line_buffering) on _TextIOBase Implement properties on _TextIOBase and StringIO Jul 17, 2025
youknowone
youknowone approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 5f1290d into RustPython:main Jul 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ever0de @youknowone