Update `test_exception*.py` from 3.13.5 #5978

ShaharNaveh · 2025-07-15T11:57:20Z

No description provided.

coderabbitai · 2025-07-15T11:57:26Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (7)

Lib/test/support/__init__.py is excluded by !Lib/**
Lib/test/test_exception_group.py is excluded by !Lib/**
Lib/test/test_exception_hierarchy.py is excluded by !Lib/**
Lib/test/test_exception_variations.py is excluded by !Lib/**
Lib/test/test_exceptions.py is excluded by !Lib/**
Lib/test/test_faulthandler.py is excluded by !Lib/**
Lib/test/test_traceback.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ShaharNaveh · 2025-07-15T11:59:47Z

Lib/test/test_exceptions.py

@@ -1765,272 +1885,6 @@ def test_name_error_has_name(self):
        except NameError as exc:
            self.assertEqual("bluch", exc.name)

-    def test_name_error_suggestions(self):


Those tests were moved to test_traceback, but when I tried to update test_traceback from 3.13.5 nothing ran. Everything was skipped because we don't have _testcapi.

How should we proceed?

Usually _testcapi is used for @cpython_only tests.
is PurePythonSuggestionFormattingTests also being skipped?

is PurePythonSuggestionFormattingTests also being skipped?

Yes:/

Could you also update test_traceback here? I will check if it is a bug of test suite or intended

Now I see that it requires has_debug_ranges. which requires the _testinternalcapi :/

RustPython/Lib/test/support/__init__.py

Lines 505 to 515 in a54873d

def has_no_debug_ranges():

try:

import _testinternalcapi

except ImportError:

raise unittest.SkipTest("_testinternalcapi required")

config = _testinternalcapi.get_config()

return not bool(config['code_debug_ranges'])

def requires_debug_ranges(reason='requires co_positions / debug_ranges'):

return unittest.skipIf(has_no_debug_ranges(), reason)

If those tests actually doesn't require that feature - because they didn't before update - writing a patch for CPython can be a solution

I'll check. my assumption is that only some of them requires it. we'll see

youknowone

👍

ShaharNaveh commented Jul 15, 2025

View reviewed changes

ShaharNaveh added 11 commits July 16, 2025 13:37

Update test_exception_group.py from 3.13.5

966d6d2

Don't skip passing test

f53a8d9

Update test_exception_variations.py from 3.13.5

e064f8c

Update test_exceptions from 3.13.5

0fbe6ce

mark failing tests

f6d755b

Update test_traceback.py from 3.13.5

2c87988

Don't require debug_ranges

55e2c97

Remove duplicated class name

323b2da

mark a failing test

058c76c

Update test_faulthandler from 3.13.5

9e22580

mark more tests

4515c61

ShaharNaveh force-pushed the update-test-exception branch from 091775d to 4515c61 Compare July 16, 2025 10:37

ShaharNaveh marked this pull request as ready for review July 16, 2025 10:49

youknowone approved these changes Jul 17, 2025

View reviewed changes

youknowone merged commit 799f38b into RustPython:main Jul 17, 2025
12 checks passed

ShaharNaveh deleted the update-test-exception branch July 17, 2025 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `test_exception*.py` from 3.13.5 #5978

Update `test_exception*.py` from 3.13.5 #5978

Uh oh!

ShaharNaveh commented Jul 15, 2025

Uh oh!

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ShaharNaveh Jul 15, 2025

Uh oh!

youknowone Jul 15, 2025

Uh oh!

ShaharNaveh Jul 15, 2025 •

edited

Loading

Uh oh!

youknowone Jul 15, 2025

Uh oh!

ShaharNaveh Jul 15, 2025

Uh oh!

youknowone Jul 15, 2025

Uh oh!

ShaharNaveh Jul 15, 2025

Uh oh!

youknowone left a comment

Uh oh!

Uh oh!

Uh oh!

	def has_no_debug_ranges():
	try:
	import _testinternalcapi
	except ImportError:
	raise unittest.SkipTest("_testinternalcapi required")
	config = _testinternalcapi.get_config()
	return not bool(config['code_debug_ranges'])

	def requires_debug_ranges(reason='requires co_positions / debug_ranges'):
	return unittest.skipIf(has_no_debug_ranges(), reason)

Update test_exception*.py from 3.13.5 #5978

Update test_exception*.py from 3.13.5 #5978

Uh oh!

Conversation

ShaharNaveh commented Jul 15, 2025

Uh oh!

coderabbitai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

ShaharNaveh Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Update `test_exception*.py` from 3.13.5 #5978

Update `test_exception*.py` from 3.13.5 #5978

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

ShaharNaveh Jul 15, 2025 •

edited

Loading