Fix SQLite large integer overflow error handling #5916

ever0de · 2025-07-09T06:37:04Z

Summary by CodeRabbit

Bug Fixes
- Improved error messages when attempting to store very large Python integers in SQLite, providing clearer feedback if the value is too large to convert.

coderabbitai · 2025-07-09T06:37:11Z

Walkthrough

The change updates the error handling in the SQLite binding logic for Python integer conversion. Instead of directly propagating conversion errors, the code now explicitly maps any integer overflow to a Python OverflowError with a specific message, refining how errors are reported during parameter binding.

Changes

File(s)	Change Summary
stdlib/src/sqlite.rs	Updated error handling in Python int to i64 conversion for SQLite binding with explicit mapping.

Poem

In the warren of code, a change takes its place,
Overflow errors now wear a clear face.
When Python ints grow too tall for the gate,
SQLite replies, “That number’s too great!”
A hop, a fix, and error messages bloom—
Rabbits rejoice: clarity resumes!

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c195473 and 35247ca.

⛔ Files ignored due to path filters (1)

Lib/test/test_sqlite3/test_userfunctions.py is excluded by !Lib/**

📒 Files selected for processing (1)

stdlib/src/sqlite.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.rs`: Follow the default rustfmt code style (`cargo fmt` to format) Always ...

**/*.rs: Follow the default rustfmt code style (cargo fmt to format)
Always run clippy to lint code (cargo clippy) before completing tasks. Fix any warnings or lints that are introduced by your changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

📄 Source: CodeRabbit Inference Engine (.github/copilot-instructions.md)

List of files the instruction was applied to:

stdlib/src/sqlite.rs

🧠 Learnings (1)

stdlib/src/sqlite.rs (1)

Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-30T10:08:48.858Z
Learning: Applies to **/*.rs : Follow Rust best practices for error handling and memory management

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run rust tests (windows-latest)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Summary of Changes

Hello @ever0de, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling mechanism within the SQLite binding logic, specifically addressing cases where Python integers exceed the capacity of SQLite's 64-bit integer type. The change ensures that users receive a clear and descriptive OverflowError when such a conversion fails, improving the diagnostic capabilities of the system.

Highlights

Error Handling Improvement: Enhanced the error handling for Python integers that are too large to be converted into a 64-bit integer (i64) for binding to SQLite. Previously, this might have resulted in a generic error, but now it explicitly raises a Python int too large to convert to SQLite INTEGER overflow error.
SQLite Binding Robustness: Improved the robustness of the sqlite3_bind_int64 function within the stdlib/src/sqlite.rs module by providing a more specific and actionable error message when integer overflow occurs during the binding process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The code changes add error handling for large integer overflows when converting Python integers to SQLite INTEGER types. The review suggests including the original error in the new error message to improve debugging.

gemini-code-assist · 2025-07-09T06:38:31Z

stdlib/src/sqlite.rs

+                let val = val.try_to_primitive::<i64>(vm).map_err(|_| {
+                    vm.new_overflow_error("Python int too large to convert to SQLite INTEGER")
+                })?;


Returning a new error without providing context about the original error makes debugging difficult. It would be helpful to include the original error in the new error message using thiserror::Error or similar.

Consider using map_err with ? to propagate the original error.

let val = val.try_to_primitive::<i64>(vm).map_err(|e| { vm.new_overflow_error(format!("Python int too large to convert to SQLite INTEGER: {}", e)) })?;

Since we are using assertRaisesRegex in Python to check the error message, we can extract the original error message from the args of PyBaseException and append it.
If you would like me to add it this way, I can submit a commit with this change.

youknowone

👍

Fix SQLite large integer overflow error handling

35247ca

gemini-code-assist bot reviewed Jul 9, 2025

View reviewed changes

ever0de marked this pull request as ready for review July 9, 2025 06:43

youknowone approved these changes Jul 9, 2025

View reviewed changes

youknowone merged commit 3413415 into RustPython:main Jul 9, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SQLite large integer overflow error handling #5916

Fix SQLite large integer overflow error handling #5916

Uh oh!

ever0de commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 9, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 9, 2025

Uh oh!

ever0de Jul 9, 2025

Uh oh!

youknowone left a comment

Uh oh!

Uh oh!

Uh oh!

Fix SQLite large integer overflow error handling #5916

Fix SQLite large integer overflow error handling #5916

Uh oh!

Conversation

ever0de commented Jul 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

ever0de Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ever0de commented Jul 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 9, 2025 •

edited

Loading