Skip to content

__class_getitem__ #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

__class_getitem__ #5888

merged 1 commit into from
Jul 3, 2025

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Added support for generic type subscripting (e.g., Class[T]) to a variety of built-in types, including arrays, context variables, bytes, bytearrays, classmethod, coroutine, generator, memoryview, range, slice, staticmethod, union, exception groups, and functools partial objects.
    • These types now allow generic aliasing using the standard subscription syntax for improved compatibility with type annotations and generic programming.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

This set of changes introduces the __class_getitem__ class method to various core and standard library types, enabling them to support generic type subscripting (e.g., Type[T]). The method is implemented across multiple classes, consistently returning a PyGenericAlias constructed from the provided arguments, with necessary import adjustments.

Changes

File(s) Change Summary
stdlib/src/array.rs Added __class_getitem__ to PyArray and imported PyGenericAlias.
stdlib/src/contextvars.rs Added __class_getitem__ to ContextVar, ContextToken, and PyContext.
vm/src/builtins/bytearray.rs, vm/src/builtins/bytes.rs Added __class_getitem__ to PyByteArray and PyBytes; imported PyGenericAlias.
vm/src/builtins/classmethod.rs, vm/src/builtins/staticmethod.rs Added __class_getitem__ to PyClassMethod and PyStaticMethod; updated imports.
vm/src/builtins/coroutine.rs, vm/src/builtins/generator.rs Added __class_getitem__ to PyCoroutine and PyGenerator; updated imports.
vm/src/builtins/memory.rs Added __class_getitem__ to PyMemoryView; imported PyGenericAlias.
vm/src/builtins/range.rs Added __class_getitem__ to PyRange.
vm/src/builtins/slice.rs Added __class_getitem__ to PySlice; imported PyGenericAlias.
vm/src/builtins/union.rs Added __class_getitem__ to PyUnion; imported PyGenericAlias.
vm/src/exceptions.rs Added __class_getitem__ to PyBaseExceptionGroup; adjusted exception attribute and imports.
vm/src/stdlib/functools.rs Added __class_getitem__ to PyPartial; imported PyGenericAlias.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant VM
    participant TypeClass
    participant PyGenericAlias

    User->>TypeClass: TypeClass[args] (subscripting)
    TypeClass->>TypeClass: __class_getitem__(cls, args, vm)
    TypeClass->>PyGenericAlias: from_args(cls, args, vm)
    PyGenericAlias-->>TypeClass: PyGenericAlias instance
    TypeClass-->>User: PyGenericAlias instance
Loading

Possibly related PRs

Suggested reviewers

  • arihant2math

Poem

In the meadow of code, a new trick appears,
Types can be subscripted—let’s all give three cheers!
__class_getitem__ hops in with style,
Making generics easy, mile after mile.
Now rabbits and coders can both exclaim:
"Type[T] works everywhere—oh, what a game!"
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0) 
Updating git repository `https://github.com/youknowone/ferrilab`

error: failed to load source for dependency radium

Caused by:
Unable to update https://github.com/youknowone/ferrilab?branch=fix-nightly#4a301c3a

Caused by:
failed to create directory /usr/local/git/db/ferrilab-ed7d38936952b47e

Caused by:
Permission denied (os error 13)

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 625496c and d61ef66.

⛔ Files ignored due to path filters (1)
  • Lib/test/test_genericalias.py is excluded by !Lib/**
📒 Files selected for processing (14)
  • stdlib/src/array.rs (2 hunks)
  • stdlib/src/contextvars.rs (3 hunks)
  • vm/src/builtins/bytearray.rs (2 hunks)
  • vm/src/builtins/bytes.rs (2 hunks)
  • vm/src/builtins/classmethod.rs (2 hunks)
  • vm/src/builtins/coroutine.rs (2 hunks)
  • vm/src/builtins/generator.rs (2 hunks)
  • vm/src/builtins/memory.rs (2 hunks)
  • vm/src/builtins/range.rs (2 hunks)
  • vm/src/builtins/slice.rs (2 hunks)
  • vm/src/builtins/staticmethod.rs (2 hunks)
  • vm/src/builtins/union.rs (2 hunks)
  • vm/src/exceptions.rs (2 hunks)
  • vm/src/stdlib/functools.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (14)
  • vm/src/builtins/classmethod.rs
  • vm/src/builtins/union.rs
  • vm/src/builtins/generator.rs
  • stdlib/src/array.rs
  • vm/src/builtins/coroutine.rs
  • vm/src/builtins/range.rs
  • vm/src/builtins/bytearray.rs
  • vm/src/builtins/memory.rs
  • vm/src/stdlib/functools.rs
  • vm/src/builtins/slice.rs
  • vm/src/builtins/bytes.rs
  • vm/src/builtins/staticmethod.rs
  • stdlib/src/contextvars.rs
  • vm/src/exceptions.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (ubuntu-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone force-pushed the __class_getitem__ branch from e91d53f to 625496c Compare July 3, 2025 00:48
@youknowone youknowone force-pushed the __class_getitem__ branch from 625496c to d61ef66 Compare July 3, 2025 01:00
@youknowone youknowone merged commit fffa735 into RustPython:main Jul 3, 2025
11 of 12 checks passed
@youknowone youknowone deleted the __class_getitem__ branch July 3, 2025 02:01
@youknowone youknowone mentioned this pull request Jul 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone