Skip to content

Commit c0d3fbb

Browse files
committed
cleaned up code
1 parent ced107b commit c0d3fbb

File tree

3 files changed

+58
-69
lines changed

3 files changed

+58
-69
lines changed

LoginLogout/LoginLogoutDB/src/java/FirstServlet.java

Lines changed: 46 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -8,61 +8,51 @@
88
*
99
* @author jacobjohn
1010
*/
11-
import java.io.IOException;
12-
import java.io.PrintWriter;
13-
import java.sql.Connection;
14-
import java.sql.DriverManager;
15-
import java.sql.PreparedStatement;
16-
import java.sql.ResultSet;
17-
18-
import javax.servlet.RequestDispatcher;
19-
import javax.servlet.ServletException;
20-
import javax.servlet.http.HttpServlet;
21-
import javax.servlet.http.HttpServletRequest;
22-
import javax.servlet.http.HttpServletResponse;
23-
11+
import java.io.*;
12+
import javax.servlet.*;
13+
import javax.servlet.http.*;
14+
import java.sql.*;
2415

25-
class Login{
26-
public static boolean validate(String name,String pass){
27-
boolean status=false;
28-
try{
29-
Class.forName("com.mysql.jdbc.Driver");
30-
Connection con=DriverManager.getConnection("jdbc:mysql://localhost:3306/JavaJDBC?autoReconnect=true&useSSL=false","root","MyNewPass");
31-
32-
PreparedStatement ps=con.prepareStatement(
33-
"select * from userreg where name=? and pass=?");
34-
ps.setString(1,name);
35-
ps.setString(2,pass);
36-
37-
ResultSet rs=ps.executeQuery();
38-
status=rs.next();
39-
40-
}catch(Exception e){System.out.println(e);}
41-
return status;
42-
}
43-
}
16+
class Login {
17+
public static boolean validate(String name, String pass) {
18+
boolean status = false;
19+
try {
20+
Class.forName("com.mysql.jdbc.Driver");
21+
Connection con = DriverManager.getConnection(
22+
"jdbc:mysql://localhost:3306/JavaJDBC?autoReconnect=true&useSSL=false", "root", "MyNewPass");
4423

45-
public class FirstServlet extends HttpServlet {
46-
public void doPost(HttpServletRequest request, HttpServletResponse response)
47-
throws ServletException, IOException {
48-
49-
response.setContentType("text/html");
50-
PrintWriter out = response.getWriter();
51-
52-
String n=request.getParameter("username");
53-
String p=request.getParameter("userpass");
54-
55-
if(Login.validate(n, p)){
56-
RequestDispatcher rd=request.getRequestDispatcher("servlet2");
57-
rd.forward(request,response);
58-
}
59-
else{
60-
out.print("Sorry username or password error");
61-
RequestDispatcher rd=request.getRequestDispatcher("index.html");
62-
rd.include(request,response);
63-
}
64-
65-
out.close();
66-
}
67-
}
68-
24+
PreparedStatement ps = con.prepareStatement("select * from userreg where name=? and pass=?");
25+
ps.setString(1, name);
26+
ps.setString(2, pass);
27+
28+
ResultSet rs = ps.executeQuery();
29+
status = rs.next();
30+
31+
} catch (Exception e) {
32+
System.out.println(e);
33+
}
34+
return status;
35+
}
36+
}
37+
38+
public class FirstServlet extends HttpServlet {
39+
public void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
40+
41+
response.setContentType("text/html");
42+
PrintWriter out = response.getWriter();
43+
44+
String n = request.getParameter("username");
45+
String p = request.getParameter("userpass");
46+
47+
if (Login.validate(n, p)) {
48+
RequestDispatcher rd = request.getRequestDispatcher("servlet2");
49+
rd.forward(request, response);
50+
} else {
51+
out.print("Sorry username or password error");
52+
RequestDispatcher rd = request.getRequestDispatcher("index.html");
53+
rd.include(request, response);
54+
}
55+
56+
out.close();
57+
}
58+
}

LoginLogout/LoginLogoutDB/src/java/WelcomeServlet.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
import java.io.IOException;
2-
import java.io.PrintWriter;
3-
4-
import javax.servlet.ServletException;
5-
import javax.servlet.http.HttpServlet;
6-
import javax.servlet.http.HttpServletRequest;
7-
import javax.servlet.http.HttpServletResponse;
1+
import java.io.*;
2+
import javax.servlet.*;
3+
import javax.servlet.http.*;
84

95
public class WelcomeServlet extends HttpServlet {
106
public void doPost(HttpServletRequest request, HttpServletResponse response)

LoginLogout/LoginLogoutDB/web/index.html

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,19 @@
55
and open the template in the editor.
66
-->
77
<html>
8+
89
<head>
910
<title>Login Page</title>
1011
<meta charset="UTF-8">
1112
<meta name="viewport" content="width=device-width, initial-scale=1.0">
1213
</head>
14+
1315
<body>
14-
<form action="servlet1" method="post">
15-
Name:<input type="text" name="username"/><br/><br/>
16-
Password:<input type="password" name="userpass"/><br/><br/>
17-
<input type="submit" value="login"/>
18-
</form>
16+
<form action="servlet1" method="post">
17+
Name:<input type="text" name="username" /><br /><br />
18+
Password:<input type="password" name="userpass" /><br /><br />
19+
<input type="submit" value="login" />
20+
</form>
1921
</body>
20-
</html>
22+
23+
</html>

0 commit comments

Comments
 (0)