Fix: allow calling C# class constructor with snake-cased arguments

jhonabreul · jhonabreul · commit 8600d8d9f68a · 2024-05-23T17:37:44.000-04:00
diff --git a/src/embed_tests/TestMethodBinder.cs b/src/embed_tests/TestMethodBinder.cs
@@ -898,6 +898,24 @@ def call_method(instance):
             Assert.IsFalse(Exceptions.ErrorOccurred());
         }
 
+        [Test]
+        public void BindsConstructorToSnakeCasedArgumentsVersion()
+        {
+            using var _ = Py.GIL();
+
+            var module = PyModule.FromString("CallsCorrectOverloadWithoutErrors", @"
+from clr import AddReference
+AddReference(""System"")
+from Python.EmbeddingTest import *
+
+def create_instance():
+    return TestMethodBinder.CSharpModel(some_argument=1, another_argument=""another argument value"")
+");
+            var exception = Assert.Throws<ClrBubbledException>(() => module.GetAttr("create_instance").Invoke());
+            var sourceException = exception.InnerException;
+            Assert.IsInstanceOf<NotImplementedException>(sourceException);
+            Assert.AreEqual("Constructor with arguments", sourceException.Message);
+        }
 
         // Used to test that we match this function with Py DateTime & Date Objects
         public static int GetMonth(DateTime test)
@@ -918,6 +936,12 @@ public CSharpModel()
                     new TestImplicitConversion()
                 };
             }
+
+            public CSharpModel(int someArgument, string anotherArgument = "another argument")
+            {
+                throw new NotImplementedException("Constructor with arguments");
+            }
+
             public void TestList(List<TestImplicitConversion> conversions)
             {
                 if (!conversions.Any())
diff --git a/src/runtime/ClassManager.cs b/src/runtime/ClassManager.cs
@@ -552,6 +552,11 @@ void AddMember(string name, string snakeCasedName, bool isStaticReadonlyCallable
                             methodList = methods[name] = new ();
                         }
                         methodList.Add(ctor, true);
+                        // Same constructor, but with snake-cased arguments
+                        if (ctor.GetParameters().Any(pi => pi.Name.ToSnakeCase() != pi.Name))
+                        {
+                            methodList.Add(ctor, false);
+                        }
                         continue;
 
                     case MemberTypes.Property:
