Skip to content

Removed MFC_MEMORY_DUMP #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed MFC_MEMORY_DUMP #953

wants to merge 2 commits into from
+0 −20

Conversation

prathi-wind
Copy link
Collaborator

@prathi-wind prathi-wind commented Jul 19, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Description

Removed code that is wrapped in ifdefs with MFC_MEMORY_DUMP since MFC_MEMORY_DUMP is never defined with any build flags

Fixes #(issue) [optional]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • What computers and compilers did you use to test this:

Checklist

  • I have added comments for the new code
  • I added Doxygen docstrings to the new code
  • I have made corresponding changes to the documentation (docs/)
  • I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
  • I have added example cases in examples/ that demonstrate my new feature performing as expected.
    They run to completion and demonstrate "interesting physics"
  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran a Rocprof Systems profile using ./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

PR Type

Other

Description

  • Remove unused MFC_MEMORY_DUMP conditional compilation blocks

  • Clean up dead code from simulation startup module

Diagram Walkthrough

flowchart LR
  A["Conditional blocks"] -- "removed" --> B["Clean code"]
  C["MFC_MEMORY_DUMP"] -- "undefined macro" --> A
Loading

File Walkthrough
Relevant files
Miscellaneous
m_start_up.fpp
Remove MFC_MEMORY_DUMP conditional blocks                               

src/simulation/m_start_up.fpp

  • Removed 5 conditional compilation blocks using MFC_MEMORY_DUMP
  • Eliminated acc_present_dump() calls and debug print statements
  • Cleaned up dead code that was never compiled
 +0/-21   

@prathi-wind prathi-wind self-assigned this Jul 19, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.06%. Comparing base (565178a) to head (bb789ee).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   44.06%   44.06%           
=======================================
  Files          68       68           
  Lines       18220    18220           
  Branches     2292     2292           
=======================================
  Hits         8029     8029           
  Misses       8821     8821           
  Partials     1370     1370

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson marked this pull request as ready for review July 19, 2025 13:32
@Copilot Copilot AI review requested due to automatic review settings July 19, 2025 13:32
@sbryngelson sbryngelson requested a review from a team as a code owner July 19, 2025 13:32
Copilot
Copilot AI reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dead code consisting of conditional compilation blocks that were wrapped in MFC_MEMORY_DUMP preprocessor directives. Since MFC_MEMORY_DUMP is never defined in any build flags, this code was never compiled or executed, making it effectively dead code that can be safely removed.

  • Removes multiple #if defined(MFC_OpenACC) && defined(MFC_MEMORY_DUMP) blocks containing acc_present_dump() calls
  • Eliminates associated debug print statements that were also conditionally compiled under the same directives
  • Cleans up unnecessary blank lines left after removing the conditional blocks

@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@qodo-merge-pro Qodo Merge Pro
Copy link

qodo-merge-pro bot commented Jul 19, 2025 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@sbryngelson
Copy link
Member

For reference, the file misc/mem_parse.sh is meant to parse this memory dump (if one ever dumps it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@sbryngelson sbryngelson sbryngelson approved these changes

Assignees

@prathi-wind prathi-wind

Labels
Review effort 1/5
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathi-wind @sbryngelson