Skip to content

Commit 5df51a1

Browse files
Samuel-DrewSamuel-Drew
committed
Updated DHFactor
updated spatialmath requirement
1 parent 04f33c4 commit 5df51a1

File tree

8 files changed

+46
-8
lines changed

8 files changed

+46
-8
lines changed

‎.idea/.gitignore

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/inspectionProfiles/profiles_settings.xml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/misc.xml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/modules.xml

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/robotics-toolbox-python.iml

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/vcs.xml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎roboticstoolbox/tools/DHFactor.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ def __init__(
5757
if not (sRest[-1] == ")" and sRest[0] == "("):
5858
raise ValueError("brackets")
5959

60-
i = 0
61-
while i < 6:
62-
if sType.lower == self.typeName[i].lower:
63-
break
64-
i += 1
65-
if i >= 6:
66-
raise ValueError("bad transform name" + sType)
60+
match = False
61+
for i in range(6):
62+
check = self.typeName[i].lower()
63+
if sType.lower == check:
64+
match = True
65+
if not match:
66+
raise ValueError("bad transform name: " + sType)
6767
self.eltype = i
6868

6969
sRest = sRest[1:-2] # get the argument from between brackets

‎setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
req = [
88
'numpy',
9-
'spatialmath-python>=0.8.2',
9+
'spatialmath-python>=0.8.3',
1010
'scipy',
1111
'matplotlib',
1212
'ansitable'

0 commit comments

Comments
 (0)