Skip to content

Test performance improvements #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Test performance improvements #4901

wants to merge 8 commits into from

Conversation

stohrendorf
Copy link
Contributor

@stohrendorf stohrendorf commented Apr 29, 2025 •
edited
Loading

Description

Follow-up to #4832.

  • Enables fork-reuse to speed up tests.
  • Makes tests dependent on Jersey locale-independent again.
  • Improves some non-deterministic tests.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@owasp-dt-bot
Copy link

owasp-dt-bot commented Apr 29, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@stohrendorf stohrendorf marked this pull request as draft April 30, 2025 04:11
stohrendorf added 5 commits May 1, 2025 09:39
@stohrendorf
ensure DB is closed after tests
fb5c804 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
reuse forks for tests to speed them up
b0318bf 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
ensure jersey tests respect the DefaultLocale annotation
7beecf2 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
fix some non-deterministic tests
e7219f3 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
make SearchManager a utility class
8e45b7e 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf stohrendorf changed the title Junit fixes Test performance improvements May 1, 2025
stohrendorf added 3 commits May 2, 2025 18:30
@stohrendorf
fixup! ensure DB is closed after tests
75b34a5 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
fixup! fix some non-deterministic tests
cf64649 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
@stohrendorf
fixup! ensure DB is closed after tests
77a2055 
Signed-off-by: Steffen Ohrendorf <steffen.ohrendorf@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stohrendorf @owasp-dt-bot