-
Notifications
You must be signed in to change notification settings - Fork 312
Add dependency on Maven Central deployment to OCI publish jobs #9204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sarahchen6
wants to merge
2
commits into
master
Choose a base branch
from
sarahchen6/change-release-job-dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1037996
Total [baseline] (10.676 s) : 0, 10676393
Agent [candidate] (1.036 s) : 0, 1036385
Total [candidate] (10.715 s) : 0, 10714740
section appsec
Agent [baseline] (1.218 s) : 0, 1217629
Total [baseline] (10.763 s) : 0, 10763194
Agent [candidate] (1.218 s) : 0, 1218195
Total [candidate] (10.793 s) : 0, 10793407
section iast
Agent [baseline] (1.174 s) : 0, 1173959
Total [baseline] (10.886 s) : 0, 10885966
Agent [candidate] (1.182 s) : 0, 1181962
Total [candidate] (11.003 s) : 0, 11002648
section profiling
Agent [baseline] (1.182 s) : 0, 1182067
Total [baseline] (10.842 s) : 0, 10842415
Agent [candidate] (1.182 s) : 0, 1182066
Total [candidate] (10.839 s) : 0, 10839040
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.42 ms) : 0, 1420
crashtracking [candidate] (1.418 ms) : 0, 1418
BytebuddyAgent [baseline] (729.632 ms) : 0, 729632
BytebuddyAgent [candidate] (727.909 ms) : 0, 727909
GlobalTracer [baseline] (240.723 ms) : 0, 240723
GlobalTracer [candidate] (240.994 ms) : 0, 240994
AppSec [baseline] (30.38 ms) : 0, 30380
AppSec [candidate] (30.421 ms) : 0, 30421
Debugger [baseline] (6.072 ms) : 0, 6072
Debugger [candidate] (5.973 ms) : 0, 5973
Remote Config [baseline] (653.142 µs) : 0, 653
Remote Config [candidate] (649.35 µs) : 0, 649
Telemetry [baseline] (8.272 ms) : 0, 8272
Telemetry [candidate] (8.167 ms) : 0, 8167
section appsec
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (751.805 ms) : 0, 751805
BytebuddyAgent [candidate] (751.841 ms) : 0, 751841
GlobalTracer [baseline] (234.616 ms) : 0, 234616
GlobalTracer [candidate] (234.621 ms) : 0, 234621
IAST [baseline] (23.347 ms) : 0, 23347
IAST [candidate] (23.558 ms) : 0, 23558
AppSec [baseline] (169.397 ms) : 0, 169397
AppSec [candidate] (166.65 ms) : 0, 166650
Debugger [baseline] (7.116 ms) : 0, 7116
Debugger [candidate] (8.728 ms) : 0, 8728
Remote Config [baseline] (611.313 µs) : 0, 611
Remote Config [candidate] (623.153 µs) : 0, 623
Telemetry [baseline] (8.103 ms) : 0, 8103
Telemetry [candidate] (9.502 ms) : 0, 9502
section iast
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (847.966 ms) : 0, 847966
BytebuddyAgent [candidate] (854.144 ms) : 0, 854144
GlobalTracer [baseline] (231.604 ms) : 0, 231604
GlobalTracer [candidate] (232.539 ms) : 0, 232539
IAST [baseline] (29.825 ms) : 0, 29825
IAST [candidate] (28.421 ms) : 0, 28421
AppSec [baseline] (28.011 ms) : 0, 28011
AppSec [candidate] (28.333 ms) : 0, 28333
Debugger [baseline] (5.753 ms) : 0, 5753
Debugger [candidate] (7.494 ms) : 0, 7494
Remote Config [baseline] (582.08 µs) : 0, 582
Remote Config [candidate] (594.611 µs) : 0, 595
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (8.013 ms) : 0, 8013
section profiling
crashtracking [baseline] (1.397 ms) : 0, 1397
crashtracking [candidate] (1.392 ms) : 0, 1392
BytebuddyAgent [baseline] (759.259 ms) : 0, 759259
BytebuddyAgent [candidate] (758.584 ms) : 0, 758584
GlobalTracer [baseline] (220.027 ms) : 0, 220027
GlobalTracer [candidate] (219.885 ms) : 0, 219885
AppSec [baseline] (30.083 ms) : 0, 30083
AppSec [candidate] (30.082 ms) : 0, 30082
Debugger [baseline] (6.235 ms) : 0, 6235
Debugger [candidate] (6.245 ms) : 0, 6245
Remote Config [baseline] (677.192 µs) : 0, 677
Remote Config [candidate] (662.293 µs) : 0, 662
Telemetry [baseline] (12.427 ms) : 0, 12427
Telemetry [candidate] (13.228 ms) : 0, 13228
ProfilingAgent [baseline] (103.688 ms) : 0, 103688
ProfilingAgent [candidate] (103.587 ms) : 0, 103587
Profiling [baseline] (103.71 ms) : 0, 103710
Profiling [candidate] (103.611 ms) : 0, 103611
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1036636
Total [baseline] (8.637 s) : 0, 8636995
Agent [candidate] (1.037 s) : 0, 1037492
Total [candidate] (8.586 s) : 0, 8585575
section iast
Agent [baseline] (1.17 s) : 0, 1170208
Total [baseline] (9.26 s) : 0, 9259889
Agent [candidate] (1.182 s) : 0, 1181785
Total [candidate] (9.303 s) : 0, 9302636
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.424 ms) : 0, 1424
BytebuddyAgent [baseline] (727.677 ms) : 0, 727677
BytebuddyAgent [candidate] (728.876 ms) : 0, 728876
GlobalTracer [baseline] (240.64 ms) : 0, 240640
GlobalTracer [candidate] (241.206 ms) : 0, 241206
AppSec [baseline] (30.409 ms) : 0, 30409
AppSec [candidate] (30.302 ms) : 0, 30302
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.005 ms) : 0, 6005
Remote Config [baseline] (643.274 µs) : 0, 643
Remote Config [candidate] (661.302 µs) : 0, 661
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (8.153 ms) : 0, 8153
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (844.674 ms) : 0, 844674
BytebuddyAgent [candidate] (853.796 ms) : 0, 853796
GlobalTracer [baseline] (230.537 ms) : 0, 230537
GlobalTracer [candidate] (232.258 ms) : 0, 232258
IAST [baseline] (26.803 ms) : 0, 26803
IAST [candidate] (26.845 ms) : 0, 26845
AppSec [baseline] (28.292 ms) : 0, 28292
AppSec [candidate] (27.598 ms) : 0, 27598
Debugger [baseline] (9.099 ms) : 0, 9099
Debugger [candidate] (10.2 ms) : 0, 10200
Remote Config [baseline] (606.169 µs) : 0, 606
Remote Config [candidate] (598.791 µs) : 0, 599
Telemetry [baseline] (7.888 ms) : 0, 7888
Telemetry [candidate] (8.029 ms) : 0, 8029
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section baseline
no_agent (36.105 ms) : 35819, 36392
. : milestone, 36105,
appsec (46.527 ms) : 46102, 46953
. : milestone, 46527,
code_origins (45.131 ms) : 44736, 45526
. : milestone, 45131,
iast (45.692 ms) : 45303, 46081
. : milestone, 45692,
profiling (48.412 ms) : 47948, 48875
. : milestone, 48412,
tracing (43.597 ms) : 43227, 43967
. : milestone, 43597,
section candidate
no_agent (36.643 ms) : 36352, 36934
. : milestone, 36643,
appsec (46.633 ms) : 46219, 47048
. : milestone, 46633,
code_origins (45.781 ms) : 45371, 46191
. : milestone, 45781,
iast (44.494 ms) : 44084, 44903
. : milestone, 44494,
profiling (47.469 ms) : 47026, 47913
. : milestone, 47469,
tracing (43.24 ms) : 42888, 43592
. : milestone, 43240,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section baseline
no_agent (4.417 ms) : 4368, 4467
. : milestone, 4417,
iast (9.487 ms) : 9335, 9639
. : milestone, 9487,
iast_FULL (13.721 ms) : 13453, 13990
. : milestone, 13721,
iast_GLOBAL (10.234 ms) : 10055, 10414
. : milestone, 10234,
profiling (9.049 ms) : 8911, 9186
. : milestone, 9049,
tracing (7.716 ms) : 7595, 7838
. : milestone, 7716,
section candidate
no_agent (4.443 ms) : 4386, 4500
. : milestone, 4443,
iast (9.581 ms) : 9419, 9742
. : milestone, 9581,
iast_FULL (14.396 ms) : 14108, 14683
. : milestone, 14396,
iast_GLOBAL (10.093 ms) : 9915, 10271
. : milestone, 10093,
profiling (8.848 ms) : 8705, 8990
. : milestone, 8848,
tracing (7.194 ms) : 7098, 7291
. : milestone, 7194,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section baseline
no_agent (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
appsec (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
iast (18.665 s) : 18665000, 18665000
. : milestone, 18665000,
iast_GLOBAL (18.135 s) : 18135000, 18135000
. : milestone, 18135000,
profiling (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
tracing (14.67 s) : 14670000, 14670000
. : milestone, 14670000,
section candidate
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (14.672 s) : 14672000, 14672000
. : milestone, 14672000,
iast (18.171 s) : 18171000, 18171000
. : milestone, 18171000,
iast_GLOBAL (18.093 s) : 18093000, 18093000
. : milestone, 18093000,
profiling (15.37 s) : 15370000, 15370000
. : milestone, 15370000,
tracing (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~0752093b59, baseline=1.52.0-SNAPSHOT~13efd646bc
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.603 ms) : 3390, 3817
. : milestone, 3603,
iast (2.2 ms) : 2137, 2262
. : milestone, 2200,
iast_GLOBAL (2.258 ms) : 2196, 2321
. : milestone, 2258,
profiling (2.069 ms) : 2017, 2121
. : milestone, 2069,
tracing (2.018 ms) : 1969, 2066
. : milestone, 2018,
section candidate
no_agent (1.49 ms) : 1478, 1501
. : milestone, 1490,
appsec (2.479 ms) : 2426, 2531
. : milestone, 2479,
iast (2.222 ms) : 2159, 2285
. : milestone, 2222,
iast_GLOBAL (2.262 ms) : 2199, 2325
. : milestone, 2262,
profiling (2.064 ms) : 2013, 2116
. : milestone, 2064,
tracing (2.023 ms) : 1975, 2072
. : milestone, 2023,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
OCI publishing jobs now depend on the
deploy_to_maven_central
job to succeed before continuing. The dependency is added to jobsinternal-publish-lib-init-tags
,promote-oci-to-prod
, andpublish-lib-init-pinned-tags
.Motivation
Previously, all OCI-related jobs were triggered as soon as the
build
step was successful. This gave little buffer between when a release begins and when OCI images are published. The additional dependency added in this PR helps to avoid prematurely publishing OCI images. The images can still be created (create-arch-specific-lib-injection-image
,create-multiarch-lib-injection-image
), internally published (oci-internal-publish
), and internally tested (oci-internal-test-publish
) as soon as thebuild
step succeeds. However, the publishing steps will only begin after the release artifacts are successfully deployed to Maven Central. In case something happens with the release and the Maven Central deployment fails, we don't want to release our OCI images and tags into customer prod envs either.Additional Notes
Descriptions of one-pipeline jobs: https://github.com/DataDog/libdatadog-build/blob/main/README.md#job-descriptions
Also considered was to add another layer of security by making these publishing jobs manually triggered. However, that's not included in order to keep the release automated. Inspiration was drawn from the
dd-trace-py
OCI image release workflow: https://github.com/DataDog/dd-trace-py/blob/main/.gitlab-ci.yml. Of course open to other ideas!Example of release pipeline before this PR's changes: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/70610397. Select

Group jobs by: Job dependencies
andShow dependencies
. Note the dependencies for the jobs below:Example pipeline for this PR: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/71083635. Again, select
Group jobs by: Job dependencies
andShow dependencies
. Note that the publishing jobs above now depend ondeploy_to_maven_central
as well.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]