-
Notifications
You must be signed in to change notification settings - Fork 312
Exclude akka http build outside the CI #9192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
apply from: "$rootDir/gradle/java.gradle" | ||
apply plugin: 'scala' | ||
apply plugin: 'call-site-instrumentation' | ||
if (project.rootProject.hasProperty("akkaRepositoryToken")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just put all the module under this if
. The diff looks more because of the formatting but it's just that
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046866
Total [baseline] (8.619 s) : 0, 8619352
Agent [candidate] (1.039 s) : 0, 1039470
Total [candidate] (8.626 s) : 0, 8625606
section iast
Agent [baseline] (1.177 s) : 0, 1176527
Total [baseline] (9.328 s) : 0, 9328218
Agent [candidate] (1.175 s) : 0, 1175038
Total [candidate] (9.3 s) : 0, 9299862
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (735.611 ms) : 0, 735611
BytebuddyAgent [candidate] (730.361 ms) : 0, 730361
GlobalTracer [baseline] (243.096 ms) : 0, 243096
GlobalTracer [candidate] (241.402 ms) : 0, 241402
AppSec [baseline] (30.676 ms) : 0, 30676
AppSec [candidate] (30.404 ms) : 0, 30404
Debugger [baseline] (6.056 ms) : 0, 6056
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (651.774 µs) : 0, 652
Remote Config [candidate] (649.952 µs) : 0, 650
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.249 ms) : 0, 8249
section iast
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (849.6 ms) : 0, 849600
BytebuddyAgent [candidate] (848.396 ms) : 0, 848396
GlobalTracer [baseline] (232.262 ms) : 0, 232262
GlobalTracer [candidate] (231.697 ms) : 0, 231697
AppSec [baseline] (27.257 ms) : 0, 27257
AppSec [candidate] (27.494 ms) : 0, 27494
Debugger [baseline] (6.715 ms) : 0, 6715
Debugger [candidate] (5.747 ms) : 0, 5747
Remote Config [baseline] (592.841 µs) : 0, 593
Remote Config [candidate] (598.332 µs) : 0, 598
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.89 ms) : 0, 7890
IAST [baseline] (29.842 ms) : 0, 29842
IAST [candidate] (30.899 ms) : 0, 30899
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040582
Total [baseline] (10.73 s) : 0, 10730170
Agent [candidate] (1.037 s) : 0, 1036568
Total [candidate] (10.698 s) : 0, 10697661
section appsec
Agent [baseline] (1.228 s) : 0, 1228137
Total [baseline] (10.898 s) : 0, 10897978
Agent [candidate] (1.234 s) : 0, 1233849
Total [candidate] (10.932 s) : 0, 10931784
section iast
Agent [baseline] (1.178 s) : 0, 1177853
Total [baseline] (10.916 s) : 0, 10916040
Agent [candidate] (1.186 s) : 0, 1186005
Total [candidate] (10.935 s) : 0, 10935462
section profiling
Agent [baseline] (1.194 s) : 0, 1193675
Total [baseline] (10.85 s) : 0, 10850153
Agent [candidate] (1.185 s) : 0, 1185172
Total [candidate] (10.877 s) : 0, 10876541
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (731.265 ms) : 0, 731265
BytebuddyAgent [candidate] (728.156 ms) : 0, 728156
GlobalTracer [baseline] (241.64 ms) : 0, 241640
GlobalTracer [candidate] (240.843 ms) : 0, 240843
AppSec [baseline] (30.378 ms) : 0, 30378
AppSec [candidate] (30.347 ms) : 0, 30347
Debugger [baseline] (5.982 ms) : 0, 5982
Debugger [candidate] (6.025 ms) : 0, 6025
Remote Config [baseline] (650.847 µs) : 0, 651
Remote Config [candidate] (652.412 µs) : 0, 652
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.217 ms) : 0, 8217
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (758.858 ms) : 0, 758858
BytebuddyAgent [candidate] (762.989 ms) : 0, 762989
GlobalTracer [baseline] (236.318 ms) : 0, 236318
GlobalTracer [candidate] (237.363 ms) : 0, 237363
IAST [baseline] (23.716 ms) : 0, 23716
IAST [candidate] (24.058 ms) : 0, 24058
AppSec [baseline] (171.204 ms) : 0, 171204
AppSec [candidate] (168.821 ms) : 0, 168821
Debugger [baseline] (5.677 ms) : 0, 5677
Debugger [candidate] (8.002 ms) : 0, 8002
Remote Config [baseline] (609.522 µs) : 0, 610
Remote Config [candidate] (623.264 µs) : 0, 623
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (8.925 ms) : 0, 8925
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (850.232 ms) : 0, 850232
BytebuddyAgent [candidate] (855.591 ms) : 0, 855591
GlobalTracer [baseline] (233.633 ms) : 0, 233633
GlobalTracer [candidate] (234.564 ms) : 0, 234564
IAST [baseline] (29.048 ms) : 0, 29048
IAST [candidate] (27.98 ms) : 0, 27980
AppSec [baseline] (27.267 ms) : 0, 27267
AppSec [candidate] (29.091 ms) : 0, 29091
Debugger [baseline] (6.707 ms) : 0, 6707
Debugger [candidate] (7.597 ms) : 0, 7597
Remote Config [baseline] (593.737 µs) : 0, 594
Remote Config [candidate] (595.721 µs) : 0, 596
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (7.949 ms) : 0, 7949
section profiling
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.398 ms) : 0, 1398
BytebuddyAgent [baseline] (765.354 ms) : 0, 765354
BytebuddyAgent [candidate] (759.943 ms) : 0, 759943
GlobalTracer [baseline] (222.087 ms) : 0, 222087
GlobalTracer [candidate] (220.842 ms) : 0, 220842
AppSec [baseline] (31.368 ms) : 0, 31368
AppSec [candidate] (30.283 ms) : 0, 30283
Debugger [baseline] (6.38 ms) : 0, 6380
Debugger [candidate] (6.287 ms) : 0, 6287
Remote Config [baseline] (691.683 µs) : 0, 692
Remote Config [candidate] (657.871 µs) : 0, 658
Telemetry [baseline] (10.395 ms) : 0, 10395
Telemetry [candidate] (14.723 ms) : 0, 14723
ProfilingAgent [baseline] (107.235 ms) : 0, 107235
ProfilingAgent [candidate] (102.388 ms) : 0, 102388
Profiling [baseline] (107.257 ms) : 0, 107257
Profiling [candidate] (102.41 ms) : 0, 102410
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (4.397 ms) : 4341, 4454
. : milestone, 4397,
iast (9.055 ms) : 8911, 9200
. : milestone, 9055,
iast_FULL (14.413 ms) : 14129, 14697
. : milestone, 14413,
iast_GLOBAL (10.344 ms) : 10164, 10524
. : milestone, 10344,
profiling (8.865 ms) : 8727, 9002
. : milestone, 8865,
tracing (7.722 ms) : 7611, 7833
. : milestone, 7722,
section candidate
no_agent (4.293 ms) : 4241, 4345
. : milestone, 4293,
iast (9.22 ms) : 9061, 9379
. : milestone, 9220,
iast_FULL (13.937 ms) : 13660, 14214
. : milestone, 13937,
iast_GLOBAL (9.774 ms) : 9592, 9957
. : milestone, 9774,
profiling (8.842 ms) : 8692, 8993
. : milestone, 8842,
tracing (7.48 ms) : 7372, 7587
. : milestone, 7480,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (35.543 ms) : 35257, 35829
. : milestone, 35543,
appsec (48.187 ms) : 47763, 48612
. : milestone, 48187,
code_origins (45.449 ms) : 45053, 45845
. : milestone, 45449,
iast (44.847 ms) : 44448, 45245
. : milestone, 44847,
profiling (49.174 ms) : 48725, 49623
. : milestone, 49174,
tracing (44.967 ms) : 44590, 45345
. : milestone, 44967,
section candidate
no_agent (38.011 ms) : 37698, 38325
. : milestone, 38011,
appsec (46.322 ms) : 45913, 46731
. : milestone, 46322,
code_origins (44.628 ms) : 44247, 45008
. : milestone, 44628,
iast (44.263 ms) : 43889, 44637
. : milestone, 44263,
profiling (46.763 ms) : 46300, 47226
. : milestone, 46763,
tracing (43.801 ms) : 43421, 44182
. : milestone, 43801,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.685 ms) : 3467, 3903
. : milestone, 3685,
iast (2.192 ms) : 2130, 2253
. : milestone, 2192,
iast_GLOBAL (2.238 ms) : 2175, 2300
. : milestone, 2238,
profiling (2.057 ms) : 2006, 2109
. : milestone, 2057,
tracing (2.005 ms) : 1956, 2053
. : milestone, 2005,
section candidate
no_agent (1.481 ms) : 1469, 1493
. : milestone, 1481,
appsec (2.454 ms) : 2402, 2507
. : milestone, 2454,
iast (2.199 ms) : 2137, 2261
. : milestone, 2199,
iast_GLOBAL (2.242 ms) : 2179, 2305
. : milestone, 2242,
profiling (2.054 ms) : 2003, 2105
. : milestone, 2054,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~97b209b7e4, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (15.553 s) : 15553000, 15553000
. : milestone, 15553000,
appsec (14.812 s) : 14812000, 14812000
. : milestone, 14812000,
iast (18.562 s) : 18562000, 18562000
. : milestone, 18562000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
. : milestone, 18058000,
profiling (15.197 s) : 15197000, 15197000
. : milestone, 15197000,
tracing (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
section candidate
no_agent (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
appsec (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
iast (18.254 s) : 18254000, 18254000
. : milestone, 18254000,
iast_GLOBAL (17.893 s) : 17893000, 17893000
. : milestone, 17893000,
profiling (15.991 s) : 15991000, 15991000
. : milestone, 15991000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
|
What Does This Do
When the akka repo token is not available it excludes the build for akka http 10+ that requires a token
I checked that the gitlab generated artifact contains the instrumentations
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]