Skip to content

Clean up envtest when it cannot start locally #4207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Jul 15, 2025

When CRDs are invalid, envtest returns an error after starting etcd and kube-apiserver. These are cleaned up now. After that, tests that need Kubernetes skip rather than starting and stopping envtest over and over.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

When CRDs are invalid, envtest returns an error after starting etcd and kube-apiserver.
These are cleaned up now. After that, tests that need Kubernetes skip
rather than starting and stopping envtest over and over.
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@cbandy cbandy merged commit f39df71 into CrunchyData:main Jul 17, 2025
20 checks passed
@cbandy cbandy deleted the envtest branch July 17, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants