Skip to content

Simplify development on macOS #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Simplify development on macOS #4206

merged 2 commits into from
Jul 14, 2025

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Jul 14, 2025

Recent macOS changes require a newer pg_query.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Testing enhancement

Other Information:

Issue: PGO-1046

This is compatible with more environments.

Co-authored-by: Ben Blattberg <ben.blattberg@crunchydata.com>
Issue: PGO-1046
Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this looks like to me is

  • your previous work on simplifying dev image builds (the Dockerfile, removing old build cruft) (none of which will interfere with our non-dev builds)
  • pg_query for newer macs -- but does it work on our older macs still?

@cbandy
Copy link
Member Author

cbandy commented Jul 14, 2025

  • pg_query for newer macs -- but does it work on our older macs still?

Yes, afaict. The change in Postgres and libpg_query work for older macOS, too.

@cbandy cbandy merged commit b53c028 into CrunchyData:main Jul 14, 2025
20 checks passed
@cbandy cbandy deleted the image branch July 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants