-
Notifications
You must be signed in to change notification settings - Fork 146
Add previous version compatibility test #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
laodouya
commented
Feb 28, 2019
- Add old bp/miner/client compatibility test
- Use common volumes in host for build bins
This reverts commit 5a00d66.
Codecov Report
@@ Coverage Diff @@
## develop #269 +/- ##
===========================================
- Coverage 80.96% 80.45% -0.51%
===========================================
Files 159 159
Lines 11914 11914
===========================================
- Hits 9646 9586 -60
- Misses 1580 1635 +55
- Partials 688 693 +5 |
leventeliu
reviewed
Feb 28, 2019
xq262144
reviewed
Feb 28, 2019
b657eb2
to
13b1951
Compare
13b1951
to
7aef69d
Compare
xq262144
reviewed
Feb 28, 2019
xq262144
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
leventeliu
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.