Skip to content

Remove cql-observer bin file and all related code. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2019

Conversation

laodouya
Copy link
Member

  1. Remove cql-observer bin file
  2. Remove cql-observer docker image
  3. Remove cql-explorer bin file

@laodouya laodouya requested review from leventeliu, auxten and xq262144 and removed request for leventeliu February 26, 2019 17:01
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #268 into develop will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop     #268     +/-   ##
==========================================
+ Coverage    80.35%   80.45%   +0.1%     
==========================================
  Files          159      159             
  Lines        11914    11914             
==========================================
+ Hits          9573     9585     +12     
+ Misses        1646     1631     -15     
- Partials       695      698      +3

@laodouya laodouya requested a review from leventeliu February 27, 2019 03:09
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@auxten auxten merged commit 2e4563a into develop Feb 27, 2019
@auxten auxten deleted the feature/remove_observer branch February 27, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants