Skip to content

Unit all docker client config to same private.key #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2019

Conversation

laodouya
Copy link
Member

@laodouya laodouya commented Feb 1, 2019

For docker-compose env:

  1. Delete unnecessary client config.
  2. Use same private key for all client role.
  3. Generate their own NodeID for each client role by same key.

@laodouya laodouya requested review from xq262144 and auxten February 1, 2019 09:54
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #247 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    75.94%   75.88%   -0.07%     
===========================================
  Files          159      159              
  Lines        12198    12198              
===========================================
- Hits          9264     9256       -8     
- Misses        2235     2243       +8     
  Partials       699      699

1 similar comment
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #247 into develop will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
- Coverage    75.94%   75.88%   -0.07%     
===========================================
  Files          159      159              
  Lines        12198    12198              
===========================================
- Hits          9264     9256       -8     
- Misses        2235     2243       +8     
  Partials       699      699

Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit b283716 into develop Feb 2, 2019
@laodouya laodouya deleted the feature/unit_client_config branch February 2, 2019 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants