Fix block producers forking on startup #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
- Coverage 76.27% 76.15% -0.13%
===========================================
Files 136 136
Lines 11179 11188 +9
===========================================
- Hits 8527 8520 -7
- Misses 1991 2005 +14
- Partials 661 663 +2 |
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
===========================================
- Coverage 76.27% 76.22% -0.06%
===========================================
Files 136 136
Lines 11179 11188 +9
===========================================
+ Hits 8527 8528 +1
- Misses 1991 2000 +9
+ Partials 661 660 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Notes
Configuring a
conf.BPStartupRequiredReachableCountwhich is greater than 1 will require the genesis time to be in the future for a genesis startup, otherwise, no BP will be able to move forward.And it also requires at least
conf.BPStartupRequiredReachableCount-1 BP(s) to be alive at any time, or the BP network will stop working forever.