Skip to content

Fix matchProvidersWithUser inconsistent #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 4, 2019
Merged

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Jan 3, 2019

No description provided.

@auxten auxten requested review from xq262144 and leventeliu January 3, 2019 09:42
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #188 into develop will increase coverage by 0.01%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##           develop     #188      +/-   ##
===========================================
+ Coverage    77.03%   77.04%   +0.01%     
===========================================
  Files          135      135              
  Lines        10799    10814      +15     
===========================================
+ Hits          8319     8332      +13     
- Misses        1836     1839       +3     
+ Partials       644      643       -1

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #188 into develop will increase coverage by 0.13%.
The diff coverage is 86%.

@@            Coverage Diff             @@
##           develop    #188      +/-   ##
==========================================
+ Coverage    76.87%     77%   +0.13%     
==========================================
  Files          135     135              
  Lines        10820   10848      +28     
==========================================
+ Hits          8318    8354      +36     
+ Misses        1857    1850       -7     
+ Partials       645     644       -1

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@auxten auxten merged commit 4c1e7d4 into develop Jan 4, 2019
@auxten auxten deleted the bugfix/matchInconsistent branch January 4, 2019 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants