Skip to content

Reduce unnecessary object copy while producing/applying new block #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2018
Merged

Reduce unnecessary object copy while producing/applying new block #158

merged 3 commits into from
Dec 26, 2018

Conversation

leventeliu
Copy link
Contributor

See makeArena comment for details.

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #158 into develop will increase coverage by 0.14%.
The diff coverage is 89.47%.

@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    76.66%   76.81%   +0.14%     
===========================================
  Files          146      146              
  Lines        10915    10920       +5     
===========================================
+ Hits          8368     8388      +20     
+ Misses        1855     1845      -10     
+ Partials       692      687       -5

1 similar comment
@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #158 into develop will increase coverage by 0.14%.
The diff coverage is 89.47%.

@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    76.66%   76.81%   +0.14%     
===========================================
  Files          146      146              
  Lines        10915    10920       +5     
===========================================
+ Hits          8368     8388      +20     
+ Misses        1855     1845      -10     
+ Partials       692      687       -5

auxten
auxten approved these changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@auxten auxten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xq262144
xq262144 approved these changes Dec 26, 2018
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@xq262144 xq262144 merged commit fcb96d3 into develop Dec 26, 2018
@laodouya laodouya deleted the feature/fullnode branch December 26, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auxten auxten auxten approved these changes

@xq262144 xq262144 xq262144 approved these changes

@zeqing-guo zeqing-guo Awaiting requested review from zeqing-guo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leventeliu @auxten @xq262144