Searchcommands: add full support for unicode

Shakeel Mohamed · Shakeel Mohamed · commit b9de11df55bb · 2018-09-27T13:40:09.000-07:00
Python's cstringio doesn't support unicode characters,
when encountering them Exceptions are raised. We've
decided to use stringio instead, trading potential
performance improvements for full unicode support.

In Python 2, this may lead to a slight performance hit
since we're no longer explicitly using the native version.

However, in Python 3 stringio will automatically use the
native version if available and there should be no noticeable
performance changes.
diff --git a/splunklib/searchcommands/internals.py b/splunklib/searchcommands/internals.py
@@ -22,7 +22,7 @@
     from collections import OrderedDict  # must be python 2.7
 except ImportError:
     from ..ordereddict import OrderedDict
-from splunklib.six.moves import cStringIO as StringIO
+from splunklib.six.moves import StringIO
 from itertools import chain
 from splunklib.six.moves import map as imap
 from json import JSONDecoder, JSONEncoder
diff --git a/splunklib/searchcommands/search_command.py b/splunklib/searchcommands/search_command.py
@@ -27,7 +27,7 @@
 except ImportError:
     from ..ordereddict import OrderedDict
 from copy import deepcopy
-from splunklib.six.moves import cStringIO as StringIO
+from splunklib.six.moves import StringIO
 from itertools import chain, islice
 from splunklib.six.moves import filter as ifilter, map as imap, zip as izip
 from splunklib import six
@@ -850,7 +850,6 @@ def _execute(self, ifile, process):
 
     @staticmethod
     def _read_chunk(ifile):
-
         # noinspection PyBroadException
         try:
             header = ifile.readline()
diff --git a/splunklib/searchcommands/validators.py b/splunklib/searchcommands/validators.py
@@ -18,7 +18,7 @@
 
 from json.encoder import encode_basestring_ascii as json_encode_string
 from collections import namedtuple
-from splunklib.six.moves import cStringIO as StringIO
+from splunklib.six.moves import StringIO
 from io import open
 import csv
 import os
diff --git a/tests/searchcommands/test_search_command.py b/tests/searchcommands/test_search_command.py
@@ -1,4 +1,5 @@
 #!/usr/bin/env python
+# coding=utf-8
 #
 # Copyright 2011-2015 Splunk, Inc.
 #
@@ -22,7 +23,7 @@
 from splunklib.searchcommands.search_command import SearchCommand
 from splunklib.client import Service
 
-from splunklib.six.moves import cStringIO as StringIO
+from splunklib.six.moves import StringIO
 from splunklib.six.moves import zip as izip
 from json.encoder import encode_basestring as encode_string
 from unittest import main, TestCase
@@ -388,7 +389,7 @@ def test_process_scpv2(self):
                         '"required_option_1=value_1",'
                         '"required_option_2=value_2"'
                     '],'
-                    '"search": "%7C%20inputlookup%20tweets%20%7C%20countmatches%20fieldname%3Dword_count%20pattern%3D%22%5Cw%2B%22%20text%20record%3Dt%20%7C%20export%20add_timestamp%3Df%20add_offset%3Dt%20format%3Dcsv%20segmentation%3Draw",'
+                    '"search": "Ａ%7C%20inputlookup%20tweets%20%7C%20countmatches%20fieldname%3Dword_count%20pattern%3D%22%5Cw%2B%22%20text%20record%3Dt%20%7C%20export%20add_timestamp%3Df%20add_offset%3Dt%20format%3Dcsv%20segmentation%3Draw",'
                     '"earliest_time": "0",'
                     '"session_key": "0JbG1fJEvXrL6iYZw9y7tmvd6nHjTKj7ggaE7a4Jv5R0UIbeYJ65kThn^3hiNeoqzMT_LOtLpVR3Y8TIJyr5bkHUElMijYZ8l14wU0L4n^Oa5QxepsZNUIIQCBm^",'
                     '"owner": "admin",'
