fix(windows): hide console window when Pythonw is used (microsoft#729)

artyl · web-flow · commit 2817a80944ef · 2021-05-31T22:07:07.000+02:00
diff --git a/playwright/_impl/_transport.py b/playwright/_impl/_transport.py
@@ -16,6 +16,7 @@
 import io
 import json
 import os
+import subprocess
 import sys
 from abc import ABC, abstractmethod
 from pathlib import Path
@@ -97,6 +98,10 @@ async def wait_until_stopped(self) -> None:
 
     async def run(self) -> None:
         self._stopped_future: asyncio.Future = asyncio.Future()
+        # Hide the command-line window on Windows when using Pythonw.exe
+        creationflags = 0
+        if sys.platform == "win32" and sys.stdout is None:
+            creationflags = subprocess.CREATE_NO_WINDOW
 
         try:
             self._proc = proc = await asyncio.create_subprocess_exec(
@@ -106,6 +111,7 @@ async def run(self) -> None:
                 stdout=asyncio.subprocess.PIPE,
                 stderr=_get_stderr_fileno(),
                 limit=32768,
+                creationflags=creationflags,
             )
         except Exception as exc:
             self.on_error_future.set_exception(exc)
