chore: Install typing-extensions only on python_version<=3.8 (microsoft#502)

kumaraditya303 · web-flow · commit 100d29e2d4e6 · 2021-02-25T10:37:32.000-08:00
diff --git a/setup.py b/setup.py
@@ -17,24 +17,18 @@
 import shutil
 import subprocess
 import sys
-import typing
 import zipfile
+from pathlib import Path
 
 import setuptools
 from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand
 
 driver_version = "1.9.0-1614037901000"
 
-with open("README.md", "r", encoding="utf-8") as fh:
-    long_description = fh.read()
-
-NoneType = type(None)
-
-
-def extractall(zip: typing.Any, path: str) -> NoneType:
+def extractall(zip: zipfile.ZipFile, path: str) -> None:
     for name in zip.namelist():
         member = zip.getinfo(name)
-        extracted_path = zip._extract_member(member, path, None)
+        extracted_path = zip.extract(member, path)
         attr = member.external_attr >> 16
         if attr != 0:
             os.chmod(extracted_path, attr)
@@ -88,7 +82,7 @@ def run(self) -> None:
             shutil.copy(base_wheel_location, wheel_location)
             with zipfile.ZipFile(wheel_location, "a") as zip:
                 driver_root = os.path.abspath(f"driver/{platform}")
-                for dir_path, dirs, files in os.walk(driver_root):
+                for dir_path, _, files in os.walk(driver_root):
                     for file in files:
                         from_path = os.path.join(dir_path, file)
                         to_path = os.path.relpath(from_path, driver_root)
@@ -108,12 +102,16 @@ def run(self) -> None:
     author="Microsoft Corporation",
     author_email="",
     description="A high-level API to automate web browsers",
-    long_description=long_description,
+    long_description=Path("README.md").read_text(encoding="utf-8"),
     long_description_content_type="text/markdown",
     url="https://github.com/Microsoft/playwright-python",
     packages=["playwright"],
     include_package_data=True,
-    install_requires=["greenlet==1.0.0", "pyee>=8.0.1", "typing-extensions"],
+    install_requires=[
+        "greenlet==1.0.0",
+        "pyee>=8.0.1",
+        "typing-extensions;python_version<='3.8'",
+    ],
     classifiers=[
         "Topic :: Software Development :: Testing",
         "Topic :: Internet :: WWW/HTTP :: Browsers",
@@ -132,7 +130,7 @@ def run(self) -> None:
         "write_to": "playwright/_repo_version.py",
         "write_to_template": 'version = "{version}"\n',
     },
-    setup_requires=["setuptools_scm"],
+    setup_requires=["setuptools_scm", "wheel"],
     entry_points={
         "console_scripts": [
             "playwright=playwright.__main__:main",
